Deprecate using null as an array offset and when calling array_key_exists()
#19511
+561
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
b1629ed to
6b521a3
Compare
TimWolla
reviewed
Aug 19, 2025
472c3c6 to
baeda1f
Compare
DanielEScherzer
requested changes
Aug 20, 2025
ext/standard/array.c
Outdated
| @@ -6981,6 +6981,7 @@ PHP_FUNCTION(array_key_exists) | |||
| RETVAL_BOOL(zend_hash_index_exists(ht, Z_LVAL_P(key))); | |||
| break; | |||
| case IS_NULL: | |||
| zend_error(E_DEPRECATED, "Using null as an array offset is deprecated, use an empty string instead"); | |||
There was a problem hiding this comment.
should we have different messages for using array offset ($foo[null]) and array key exists (array_key_exists(null, $foo))?
There was a problem hiding this comment.
I pushed "Using null as the key parameter for array_key_exists() is deprecated, use an empty string instead". What do you think?
baeda1f to
a6d44e0
Compare
d5fd9e5 to
a602268
Compare
|
Still a few tests to fix but we're getting closer |
6f50c89 to
e508fcc
Compare
fd39b6d to
8f22921
Compare
8f22921 to
dc5049b
Compare
arnaud-lb
reviewed
Aug 21, 2025
| @@ -2629,6 +2629,7 @@ static zend_never_inline uint8_t slow_index_convert(HashTable *ht, const zval *d | |||
| ZEND_FALLTHROUGH; | |||
| } | |||
| case IS_NULL: | |||
| zend_error(E_DEPRECATED, "Using null as an array offset is deprecated, use an empty string instead"); | |||
There was a problem hiding this comment.
You will need to addref/delref ht around this, because ht may be freed by an error handler:
set_error_handler(function($errno, $errstr) {
global $ary;
$ary = null;
echo $errstr;
});
$ary[null] = 1; // AddressSanitizer: heap-use-after-freeSee case IS_DOUBLE as an example
| @@ -2699,6 +2700,7 @@ static zend_never_inline uint8_t slow_index_convert_w(HashTable *ht, const zval | |||
| ZEND_FALLTHROUGH; | |||
| } | |||
| case IS_NULL: | |||
| zend_error(E_DEPRECATED, "Using null as an array offset is deprecated, use an empty string instead"); | |||
| @@ -3324,6 +3326,9 @@ static zend_never_inline bool ZEND_FASTCALL zend_array_key_exists_fast(HashTable | |||
| } else if (Z_TYPE_P(key) <= IS_NULL) { | |||
| if (UNEXPECTED(Z_TYPE_P(key) == IS_UNDEF)) { | |||
| ZVAL_UNDEFINED_OP1(); | |||
| } else { | |||
| ZEND_ASSERT(Z_TYPE_P(key) == IS_NULL); | |||
| zend_error(E_DEPRECATED, "Using null as the key parameter for array_key_exists() is deprecated, use an empty string instead"); | |||
There was a problem hiding this comment.
Probably here as well (I'm not sure)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19468
RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_using_values_null_as_an_array_offset_and_when_calling_array_key_exists
cc @Girgias