Improve error and exception handlers #20
Conversation
This allows the error handler to be reset using set_error_handler(null). As the code suggests this behavior was already previously intended, but the callback check was done too strictly.
set_error_handler(null) and set_exception_handler(null) now return the previous error/exception handler instead of just returning bool(true). This is consistent with the behavior of these functions with non-null values.
|
Definitely needs a note in UPGRADING and NEWS. Otherwise looks fine to me. |
|
@smalyshev Should I add that to the PR? I thought that would not merge well. And speaking about merging: Do you still think that this is only eligible for master? Quoting my last mail regarding this on internals:
|
|
whats the status on that? Do we get an update version including UPGRADING and NEWS notes? |
|
Comment on behalf of nikic at php.net: This is now merged, but only for master: a31fa55...5de79f9 |
The first commit allows resetting the error handler using
set_error_handler(null).The second commit changes the behavior of both
set_error_handler(null)andset_exception_handler(null)to return the previous error/exception handler. This makes the resetting consistent with the normal behavior and addresses the comments by Stas and Pierre.The third commit cleans up the code a bit.
This is a followup to PR #18 and bug https://bugs.php.net/bug.php?id=60738.