Fixed typo - inconsistent notice for undefined property (introduced by fix for #49348) #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y fix for #49348)
|
seems fine... |
|
only one issue here, the fix seems also applied to 5.5, but your fix is only against master... |
|
Comment on behalf of laruence at php.net: cherry-picked in 70668fd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message added as a fix for #49348 (0c6d903) is not consistent with the other one triggered in similar case.
Consider the following code:
Currently, it triggers two notices:
Notice: Undefined property: foo
Notice: Undefined property: stdClass::$bar
The first one was added by the fix for #49348 and is inconsistent with other notices related to property access. It should be same as the other one (should contain classname, :: and dollar).
(I already commented on bugs.php.net and here in #281, but noone cared.)