Skip to content

Fixed typo - inconsistent notice for undefined property (introduced by fix for #49348) #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed typo - inconsistent notice for undefined property (introduced by fix for #49348) #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Zend/tests/bug52041.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,29 +35,29 @@ Notice: Undefined variable: x in %sbug52041.php on line 3

Warning: Creating default object from empty value in %sbug52041.php on line 8

Notice: Undefined property: a in %sbug52041.php on line 8
Notice: Undefined property: stdClass::$a in %sbug52041.php on line 8

Notice: Undefined variable: x in %sbug52041.php on line 3

Notice: Undefined property: a in %sbug52041.php on line 9
Notice: Undefined property: stdClass::$a in %sbug52041.php on line 9

Warning: Creating default object from empty value in %sbug52041.php on line 9

Notice: Undefined property: b in %sbug52041.php on line 9
Notice: Undefined property: stdClass::$b in %sbug52041.php on line 9

Notice: Undefined variable: x in %sbug52041.php on line 3

Warning: Creating default object from empty value in %sbug52041.php on line 10

Notice: Undefined property: a in %sbug52041.php on line 10
Notice: Undefined property: stdClass::$a in %sbug52041.php on line 10

Notice: Undefined variable: x in %sbug52041.php on line 3

Notice: Undefined property: a in %sbug52041.php on line 11
Notice: Undefined property: stdClass::$a in %sbug52041.php on line 11

Warning: Creating default object from empty value in %sbug52041.php on line 11

Notice: Undefined property: b in %sbug52041.php on line 11
Notice: Undefined property: stdClass::$b in %sbug52041.php on line 11

Notice: Undefined variable: x in %sbug52041.php on line 3

Expand Down
2 changes: 1 addition & 1 deletion Zend/tests/bug60536_001.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ echo "DONE";
?>
--EXPECTF--

Notice: Undefined property: x in %s on line 14
Notice: Undefined property: Z::$x in %s on line 14
DONE
2 changes: 1 addition & 1 deletion Zend/tests/bug62005.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ add_points(NULL, 2);
--EXPECTF--
Warning: Creating default object from empty value in %sbug62005.php on line %d

Notice: Undefined property: energy in %sbug62005.php on line 3
Notice: Undefined property: stdClass::$energy in %sbug62005.php on line 3
stdClass Object
(
[energy] => 2
Expand Down
2 changes: 1 addition & 1 deletion Zend/zend_object_handlers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,7 +755,7 @@ static zval **zend_std_get_property_ptr_ptr(zval *object, zval *member, int type
new_zval = &EG(uninitialized_zval);

if(UNEXPECTED(type == BP_VAR_RW || type == BP_VAR_R)) {
zend_error(E_NOTICE, "Undefined property: %s", Z_STRVAL_P(member));
zend_error(E_NOTICE, "Undefined property: %s::$%s", zobj->ce->name, Z_STRVAL_P(member));
}
Z_ADDREF_P(new_zval);
if (EXPECTED((property_info->flags & ZEND_ACC_STATIC) == 0) &&
Expand Down
14 changes: 7 additions & 7 deletions tests/classes/implicit_instantiation_001.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ var_dump($c);

Warning: Creating default object from empty value in %s on line 18

Notice: Undefined property: prop in %s on line 18
Notice: Undefined property: stdClass::$prop in %s on line 18

--> Attempting implicit conversion to object using assignment...

Expand All @@ -51,15 +51,15 @@ Warning: Creating default object from empty value in %s on line 22

Warning: Creating default object from empty value in %s on line 26

Notice: Undefined property: prop in %s on line 26
Notice: Undefined property: stdClass::$prop in %s on line 26


---( $c->emptyString )---
--> Attempting implicit conversion to object using increment...

Warning: Creating default object from empty value in %s on line 18

Notice: Undefined property: prop in %s on line 18
Notice: Undefined property: stdClass::$prop in %s on line 18

--> Attempting implicit conversion to object using assignment...

Expand All @@ -69,15 +69,15 @@ Warning: Creating default object from empty value in %s on line 22

Warning: Creating default object from empty value in %s on line 26

Notice: Undefined property: prop in %s on line 26
Notice: Undefined property: stdClass::$prop in %s on line 26


---( $c->null )---
--> Attempting implicit conversion to object using increment...

Warning: Creating default object from empty value in %s on line 18

Notice: Undefined property: prop in %s on line 18
Notice: Undefined property: stdClass::$prop in %s on line 18

--> Attempting implicit conversion to object using assignment...

Expand All @@ -87,7 +87,7 @@ Warning: Creating default object from empty value in %s on line 22

Warning: Creating default object from empty value in %s on line 26

Notice: Undefined property: prop in %s on line 26
Notice: Undefined property: stdClass::$prop in %s on line 26


---( $c->boolTrue )---
Expand Down Expand Up @@ -155,4 +155,4 @@ Warning: Attempt to assign property of non-object in %s on line 26
%unicode|string%(5) "hello"
[%u|b%"intZero"]=>
int(0)
}
}