Skip to content

Fixed #65225: PHP_BINARY incorrectly set #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2013

Conversation

patrickallaert
Copy link
Contributor

@weltling
Copy link
Contributor

Could you please add a test case?

@patrickallaert
Copy link
Contributor Author

@weltling I considered that, but a bit unsure about the logic to use since:

  1. Creating the "/usr/local/bin/php" directory wouldn't cause the bug if created from the same PHP instance as PHP_BINARY constant is created at the very beginning.
  2. /usr/local/bin may not be in $PATH
  3. /usr/local/bin/php may already exist
  4. /usr/local/bin/php might not be writeable

Any suggestion on how to test it?

@weltling
Copy link
Contributor

@patrickallaert if /usr/local is absolutely necessary, you can check in --SKIPIF--. But normally you could manipulate the PATH in the --ENV-- section for completely different location so the situation can be modelled.

@php-pulls php-pulls merged commit b980e4f into php:master Aug 18, 2013
@patrickallaert patrickallaert deleted the bug-65225 branch August 26, 2013 12:01
@patrickallaert patrickallaert restored the bug-65225 branch September 4, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants