-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
PhpExecutableFinder::find() does not always return the correct binary #8455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
patrickallaert
added a commit
to patrickallaert/symfony
that referenced
this issue
Jul 9, 2013
…ways return the correct binary
fabpot
pushed a commit
that referenced
this issue
Jul 21, 2013
fabpot
added a commit
that referenced
this issue
Jul 21, 2013
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #8456). Discussion ---------- [Process] Fixed #8455: PhpExecutableFinder::find() does not always return the correct binary Since `PHP_BINARY` is the very first approach considered, there is no way to use a workaround like setting the `PHP_PATH`. Checking `PHP_PATH` could potentially be put before checking `PHP_BINARY`: that would avoid an extra function call (and system call), at the price of a small BC_BREAK, but I think it's better in this case to have a solution that doesn't force people to set the `PHP_PATH` environment variable. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8455 | License | MIT | Doc PR | none Commits ------- 35a2fe4 [Process] Fixed #8455: PhpExecutableFinder::find() does not always return the correct binary
fabpot
added a commit
that referenced
this issue
Jul 21, 2013
* 2.2: [Validator] fixed ConstraintViolation:: incorrect when nested handle Optional and Required constraints from XML or YAML sources correctly added missing comments to WebTestCase Fixed #8455: PhpExecutableFinder::find() does not always return the correct binary [DependencyInjection] Fix Container::camelize to convert beginning and ending chars [Validator] Fixed groups argument misplace for validateValue method from validator class Conflicts: src/Symfony/Component/Validator/Tests/Constraints/CollectionTest.php src/Symfony/Component/Validator/Tests/GraphWalkerTest.php
fabpot
added a commit
that referenced
this issue
Jul 21, 2013
* 2.3: [Validator] fixed ConstraintViolation:: incorrect when nested handle Optional and Required constraints from XML or YAML sources correctly added missing comments to WebTestCase Fixed #8455: PhpExecutableFinder::find() does not always return the correct binary Added missing files .gitignore [DependencyInjection] Fix Container::camelize to convert beginning and ending chars [Validator] Fixed groups argument misplace for validateValue method from validator class [Form] Fix of "PATCH'ed forms are never valid"
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this issue
Mar 25, 2018
* 2.3: [Validator] fixed ConstraintViolation:: incorrect when nested handle Optional and Required constraints from XML or YAML sources correctly added missing comments to WebTestCase Fixed symfony#8455: PhpExecutableFinder::find() does not always return the correct binary Added missing files .gitignore [DependencyInjection] Fix Container::camelize to convert beginning and ending chars [Validator] Fixed groups argument misplace for validateValue method from validator class [Form] Fix of "PATCH'ed forms are never valid"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PhpExecutableFinder::find()
partially relies onPHP_BINARY
constant which suffers of issue: https://bugs.php.net/65225 : "PHP_BINARY incorrectly set", for which I submitted a PR at: php/php-src#381 but it will take time before php binaries gets fixed in distributions.The text was updated successfully, but these errors were encountered: