Skip to content

Add stubs for PDO #4803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add stubs for PDO #4803

wants to merge 1 commit into from

Conversation

kocsismate
Copy link
Member

I am opening the PR in order to be visible that work has started on this module. (Currently, the stubs are just copied from the documentation)

@cmb69 cmb69 added the Stubs label Oct 9, 2019
carusogabriel
carusogabriel suggested changes Oct 9, 2019
View reviewed changes
kocsismate
kocsismate commented Oct 9, 2019
View reviewed changes
Copy link
Member Author

@kocsismate kocsismate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried my best (which is not much from someone who hasn't touched C in this decade), so please carefully review ^^

@kocsismate kocsismate changed the title [WIP] Add stub for PDO Add stub for PDO Oct 9, 2019
carusogabriel
carusogabriel suggested changes Oct 10, 2019
View reviewed changes
@kocsismate kocsismate force-pushed the pdo-stub branch 3 times, most recently from c7c2832 to 6a48ccc Compare October 10, 2019 14:11
@kocsismate kocsismate changed the title Add stub for PDO Add stubs for PDO Oct 11, 2019
@kocsismate kocsismate mentioned this pull request Oct 18, 2019
Closed
4 tasks
@kocsismate kocsismate mentioned this pull request Nov 17, 2019
Closed
@cmb69
Copy link
Member

cmb69 commented Nov 18, 2019

Thanks @kocsismate (and also thanks to @tvlooy). Applied as 100552d.

@cmb69 cmb69 closed this Nov 18, 2019
@kocsismate kocsismate deleted the pdo-stub branch November 18, 2019 11:46
@nikic
Copy link
Member

nikic commented Nov 19, 2019

Looks like this broke Doctrine:

Fatal error: Declaration of Doctrine\DBAL\Driver\PDOConnection::query() must be compatible with PDO::query(string $statement) in /home/vsts/work/1/s/framework/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php on line 70

Previously the query() signature was not checked because it used NULL for arginfo. The change looks fine to me though (for PHP 8) and Doctrine will have to add the $statement parameter. cc @Ocramius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic left review comments

@cmb69 cmb69 cmb69 left review comments

@carusogabriel carusogabriel carusogabriel requested changes

Assignees
No one assigned
Labels
Stubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kocsismate @cmb69 @nikic @carusogabriel