Skip to content

WIP: Add ext/pdo stubs #4915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

WIP: Add ext/pdo stubs #4915

wants to merge 2 commits into from

Conversation

tvlooy
Copy link
Contributor

@tvlooy tvlooy commented Nov 15, 2019

No description provided.

@tvlooy tvlooy changed the title Add ext/pdo stubs WIP: Add ext/pdo stubs Nov 15, 2019
@cmb69 cmb69 added the Stubs label Nov 15, 2019
@kocsismate
Copy link
Member

kocsismate commented Nov 17, 2019 •
edited
Loading

Hey @tvlooy, I've already done this in #4803.

@cmb69 @nikic could you please review the outstanding stub PRs when you have time in order to avoid conflicting works?

@tvlooy
Copy link
Contributor Author

tvlooy commented Nov 17, 2019

whoops. Last time I checked it wasn't there yet. Thanks for giving me a heads up!

@tvlooy tvlooy closed this Nov 17, 2019
@kocsismate
Copy link
Member

Yeah, it's a bit unfortunate that there are way too many open PRs to review for basically just 2-3 people. ☹️ so some PRs can easily stay hidden.

@tvlooy
Copy link
Contributor Author

tvlooy commented Nov 17, 2019

no it's just my mistake. I checked on 3 nov and should have checked again before starting work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tvlooy @kocsismate @cmb69 @carusogabriel