Improve rendering of lines in 3D (against disappearing in certain angles) issue #691 #3128
Conversation
package.json
Outdated
| @@ -74,7 +74,7 @@ | |||
| "gl-contour2d": "^1.1.4", | |||
| "gl-error3d": "^1.0.7", | |||
| "gl-heatmap2d": "^1.0.4", | |||
| "gl-line3d": "^1.1.2", | |||
| "gl-line3d": "git://github.com/gl-vis/gl-line3d.git#dfbd94f4290d30097c9b7c9f36d2a241732124c0", | |||
There was a problem hiding this comment.
|
Thanks @archmoj - In the image tests I see a bunch of minor changes but nothing that I can clearly point to and say "yes, that was a bug and now it's fixed." Can you include a new image, like the one posted in #691, to make it obvious what was fixed? Then, since it doesn't generate a diff, post a screenshot in a comment "here's what this image looks like on the master branch, notice the missing line between the top two points" or whatever. I do think I see something a little odd, the change in gl3d_set-ranges - the clipped line got a little bit longer, and if I rotate the scene it looks like it's popping out the top just a tiny bit: |
|
Before: |
|
Thanks - that before/after comparison is exactly what I wanted to see. The segment joins definitely look better now 🌟 |
|
Yes I've already added this to the image test. But I would like to possibly add few other traces to better show the changes. |
|
To compare previous and new images: |
|
To compare previous gl-line3d with new gl-line3d performance, please view old & new images here: |
| @@ -74,7 +74,7 @@ | |||
| "gl-contour2d": "^1.1.4", | |||
| "gl-error3d": "^1.0.7", | |||
| "gl-heatmap2d": "^1.0.4", | |||
| "gl-line3d": "^1.1.2", | |||
| "gl-line3d": "git://github.com/gl-vis/gl-line3d.git#33b9e850de754cde38d859328ae562125edc90f2", | |||
|
Closing in favour of #3163 |
Previously the angles computed in the
gl-plot3dmodule necessary to match rectangle shapes towards camera point were not accurate. Therefore 2D representations of 3D lines were not oriented properly in various perspective angles. Disappearing and tininess impacts resulted from the bug could be clearly observed namely when the thicknesses of lines usingscatter3dwere increased. Please refer to the issue #691 for more information.This PR improves rendering of lines in 3D scenes by performing proper 3D/2D calculations within the webgl vertex shader of the module.
@alexcjohnson