Fix stack with gaps bar height bug #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- before dd2251d bar for non-numeric size were excluded from the calcdata, which led to wrong bar widths in traces with gaps. However, this made setPositions stack non-numeric bars.
|
Nice code:test ratio! 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #627
In brief, we must skip over bars with non-numeric sizes in the
setPositionsstep now.Before commit dd2251d bars with non-numeric sizes were excluded from the
gd.calcdata. This, in turn, led to wrong bar widths in bar traces containing gaps. However, commit dd2251d madeBar.setPositionsattempt to stack non-numeric bars as described in #627. More info in b7f7944 .Moreover, this PR adds a few features to our custom jasmine matchers. Namely,
toBeCloseToArrayandtoBeCloseTo2DArraycan now display per-call extra message and does not try to compute the distance between non-numeric elements in arrays.