Skip to content

FF requires numpy #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 18, 2017
Merged

FF requires numpy #667

merged 2 commits into from
Jan 18, 2017

Conversation

theengineear
Copy link
Contributor

Note that we don’t necessarily require numpy for in all the FF
methods. We’re just looking to make the compatibility-breaking
change so that we can depend on it in 2.0.0.

Also note that I’d forgotten to include figure_factory in setup.py
before ;__;.

@theengineear
Copy link
Contributor Author

@chriddyp for review. Seem ok?

//cc @choldgraf 😸 just some setup towards a faster figure factory methods.

@theengineear theengineear mentioned this pull request Jan 18, 2017
Merged
@theengineear
Copy link
Contributor Author

^^ huh, rebuilt, seems like an intermittent npm fail?

@choldgraf
Copy link
Contributor

sweet! thx for keeping me in the loop

@theengineear theengineear mentioned this pull request Jan 18, 2017
Closed
10 tasks
chriddyp
chriddyp reviewed Jan 18, 2017
View reviewed changes
Copy link
Member

@chriddyp chriddyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@theengineear
Fail if user tries to import FF without numpy.
9138516 
Note that we don’t necessarily *require* `numpy` for in all the FF
methods. We’re just looking to make the compatibility-breaking
change so that we can depend on it in `2.0.0`.

Also note that I’d forgotten to include `figure_factory` in setup.py
before ;__;.
@theengineear
Move all FF tests into test_optional.
7e3b358
@theengineear theengineear merged commit b81d9f1 into 2.0.0 Jan 18, 2017
@theengineear theengineear deleted the ff-requires-numpy branch January 18, 2017 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriddyp chriddyp chriddyp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theengineear @choldgraf @chriddyp