Skip to content

[MRG] Candlestick andothers #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 21, 2019
Merged

[MRG] Candlestick andothers #11

merged 13 commits into from
Jun 21, 2019

Conversation

emmanuelle
Copy link
Contributor

@emmanuelle emmanuelle commented Jun 12, 2019

Notebooks refreshed here:

  • candlestick
  • table
  • network-graphs
  • box-plots
  • gantt (for this one I had to make a PR to plotly.py since the ff did not return a go.Figure)
  • sankey-diagram
  • filled-area-plots
  • distplot
  • tree-plots
  • bubble-charts

@emmanuelle
Copy link
Contributor Author

This is a bunch of notebooks, ready for review. I went quickly through the tree-plots one, it seemed of more minor importance to me.

@emmanuelle emmanuelle changed the title Candlestick andothers [MRG] Candlestick andothers Jun 16, 2019
@emmanuelle
Copy link
Contributor Author

Anything else I can do for this PR or is it good to go?

@emmanuelle
Copy link
Contributor Author

Updated update_layout and graph_objects.

@nicolaskruchten
Copy link
Contributor

This is good to go: 💃

I would recommend doing Violin and OHLC very soon, as those pages should be essentially the same as Box and Candlestick, respectively, and should probably crosslink :)

@emmanuelle emmanuelle merged commit 3769dac into master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants