Skip to content

fit property doc is wrong? #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolaskruchten opened this issue Jan 17, 2018 · 3 comments
Closed

fit property doc is wrong? #30

nicolaskruchten opened this issue Jan 17, 2018 · 3 comments
Assignees
@nicolaskruchten

Comments

@nicolaskruchten
Copy link
Contributor

The fit property documentation appears to be wrong in that any existing layout.width or layout.height is not ignored... Need to decide if the docs should be updated to match the implementation or vice versa.
@nicolaskruchten nicolaskruchten self-assigned this Jan 17, 2018
@stephanembl
Copy link

fit doesn't seem to work properly at all, wether height&width are set or not. It creates a 700x450 SVG on my side...

@nicolaskruchten
Copy link
Contributor Author

I'll try to put together a simple example of it working, because it does fit to the containing element, but it's quite sensitive to the CSS around it it seems.

nicolaskruchten added a commit that referenced this issue Jan 23, 2018
@nicolaskruchten
fix for #30 and #22
bb85f42
@nicolaskruchten nicolaskruchten mentioned this issue Jan 23, 2018
Merged
nicolaskruchten added a commit that referenced this issue Jan 23, 2018
@nicolaskruchten
fix for #30 and #22
7896a4e
@nicolaskruchten
Copy link
Contributor Author

I've improved the documentation and marked this prop as 'deprecated' for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolaskruchten nicolaskruchten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicolaskruchten @stephanembl