Skip to content

add className prop, deprecate fit prop #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2018
Merged

add className prop, deprecate fit prop #35

merged 2 commits into from
Jan 23, 2018

Conversation

nicolaskruchten
Copy link
Contributor

fix for #30 and #22

@bpostlethwaite
Copy link
Member

What is the alternative to fit - removing width and height and setting autosize: true`? Should we document this?

@nicolaskruchten
Copy link
Contributor Author

updated readme.

@bpostlethwaite
Copy link
Member

Should we document the case where a user can "fit once" by doing all said steps you added minus the useRelayoutHandler?

Not blocking though 💃

@nicolaskruchten
Copy link
Contributor Author

Well, that's basically just "knowing how plotly.js works" :)

@nicolaskruchten nicolaskruchten merged commit 9dc4e4f into master Jan 23, 2018
@nicolaskruchten nicolaskruchten deleted the classname branch January 23, 2018 21:36
@nicolaskruchten nicolaskruchten restored the classname branch May 2, 2018 17:03
@nicolaskruchten nicolaskruchten deleted the classname branch May 2, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpostlethwaite bpostlethwaite Awaiting requested review from bpostlethwaite

@VeraZab VeraZab Awaiting requested review from VeraZab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolaskruchten @bpostlethwaite