Support PyPy #515
Closed
Support PyPy #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests seem to be failing since this is a PR from a fork, but I validated it builds successfully on my machine. |
|
@rsyring I created a native branch with all the changes in this repo to check if the build passes. If it does, I'll merge it - unless you have any objections. https://travis-ci.org/pymssql/pymssql/jobs/301628701 |
rsyring
reviewed
Nov 13, 2017
| */ | ||
| #ifndef PyByteArray_Check | ||
| #define PyByteArray_Check(self) (0) | ||
| #endif |
There was a problem hiding this comment.
Would like to see a newline at the end of each file.
|
@yuvalbar could we update CI so that we are also doing a test run with PyPI? |
|
@yuvalbar Thanks. Did the tests get updated to run these changes? Do you just want to create a new PR with the native branch so we can see the tests results in the PR? |
|
Closed in favor of #517 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows PyMSSQL to compile on PyPy. It is based on this PR: #309. I rebased the branch on the current master and made the changes requested in the linked PR to ensure it compiles properly.