Use Literal.__new__ to select optimized subclasses #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turns Literal() into a factory which creates an object of the appropriate type from the start, rather than having to overwrite the __class__ attribute later.
Codecov Report
@@ Coverage Diff @@
## master #413 +/- ##
==========================================
+ Coverage 90.87% 91.10% +0.22%
==========================================
Files 11 11
Lines 3935 3946 +11
Branches 955 957 +2
==========================================
+ Hits 3576 3595 +19
+ Misses 213 206 -7
+ Partials 146 145 -1
Continue to review full report at Codecov.
|
Instance attributes from superclasses weren't being transferred to the copy. Regression test included.
This unifies the logic with other optimized literal classes like _SingleCharLiteral, and it seemed right in terms of a type relationship.
If |
ptmcg
reviewed
Jun 16, 2022
|
Also nice to get rid of the assignment to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns
Literal()into a factory which creates an object of the appropriate type from the start, rather than having to overwrite the__class__attribute later.See #412 for the suggestion.
Question: should
Emptybe made a subclass ofLiteral? It seems to make sense that it would be.