Skip to content

Kill previous worker if another eval/execute is asked to the donkey #2218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2024
Merged

Kill previous worker if another eval/execute is asked to the donkey #2218

merged 3 commits into from
Oct 11, 2024

Conversation

WebReflection
Copy link
Contributor

@WebReflection WebReflection commented Oct 11, 2024 •
edited
Loading

Description

This MR fixes #2214 and overrides #2217 by refactoring entirely the donkey logic.

Changes

  • used a Promise based helper to bootstrap a worker with a Blob
  • resolved the donkey with a "farmer" wrapper that can be killed/nullified and resurrected (apologies for the metaphor no farmer got hurt in the making/process)
  • tested manually that if a worker is stuck, even via an input, a new Run can happen and the previous worker is just gone

Checklist

  • I have checked make build works locally.
  • I have created / updated documentation for this change (if applicable).

@WebReflection WebReflection mentioned this pull request Oct 11, 2024
Closed
2 tasks
@WebReflection WebReflection changed the base branch from better-donkey to main October 11, 2024 11:40
@WebReflection WebReflection force-pushed the better-donkey branch 2 times, most recently from 039c081 to cf9c726 Compare October 11, 2024 11:53
@WebReflection WebReflection requested a review from ntoll October 11, 2024 11:53
@WebReflection WebReflection force-pushed the better-donkey branch 2 times, most recently from 819a12b to 8b3bc4f Compare October 11, 2024 12:01
@WebReflection WebReflection merged commit b1c33b7 into pyscript:main Oct 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntoll ntoll ntoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kill previous worker if another eval/execute is asked to the donkey
2 participants
@WebReflection @ntoll