-
Notifications
You must be signed in to change notification settings - Fork 9
Update to 2024.6.1 release / add community link and README #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
there was a question for me, sorry ... premature approval, but it's draft .... so, I don't know what you are referring to, any previous / current state? what am I looking at? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to understand what is it that I am looking at that fails ... revoking my previous approval as that was premature, sorry.
@WebReflection hey hey... the problem is in the way the "fake typed in code" is handled in this version compared to the current version on pyscript.net. The newline etc... doesn't work as expected. So something in PyScript itself has changed (because the code for the website hasn't changed). |
@ntoll I've no idea how to test any of this ... I don't know how to reproduce the issue, if you have a link to the current MR state that helps, otherwise please let me know how I can reproduce anything you are saying locally. The README is non-existent and I don't know how to test this MR at all, thanks! |
If I should copy and paste changed files somewhere that's fine too but I struggle to understand how MR lands in here ... I can test files manually though, still ... this repo needs some helping out for people not previously involved with it, imho. |
My apologies... just run the website locally. Compare the "terminal" output with pyscript.net. |
I still think having a README or any other I hope this explain the current fix ... we clean the line and return then MicroPython re-write the chars to parse and then executes these showing the result. |
OK. Readme added. Will discuss changes in today's community call. |
FWIW - @laffra just asked for this very (discord) feature. I'm gonna merge since lots of folks are asking for it. |
I had a few embarrassing moments at Goto Amsterdam when I wanted to point people to the Discord server to join the community. However, I could not find it anywhere 🤦 |
This change causes Brave to go into an infinite refresh loop. Uploading pyscript.net broken.mov… |
After a moment, the Brave related problem went away. Putting this down to a weird Heisenbug. |
This PR introduces two changes: