Skip to content

Update to 2024.6.1 release / add community link and README #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Conversation

ntoll
Copy link
Member

@ntoll ntoll commented Jun 10, 2024

This PR introduces two changes:

  • Based on several pieces of feedback from PyCon - we have no direct link to our community channels on discord. This PR fixes this by replacing the joke-y superfluous "Install PyScript" button (hint: you don't install it) with a link to discord.
  • Updated to PyScript 20204.6.1 - @WebReflection the opening example code that's "typed" into the console no longer looks right. Any idea what's going on?

@ntoll ntoll requested a review from WebReflection June 10, 2024 13:16
@WebReflection
Copy link
Contributor

there was a question for me, sorry ... premature approval, but it's draft .... so, I don't know what you are referring to, any previous / current state? what am I looking at?

Copy link
Contributor

@WebReflection WebReflection left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to understand what is it that I am looking at that fails ... revoking my previous approval as that was premature, sorry.

@ntoll
Copy link
Member Author

ntoll commented Jun 10, 2024

@WebReflection hey hey... the problem is in the way the "fake typed in code" is handled in this version compared to the current version on pyscript.net. The newline etc... doesn't work as expected. So something in PyScript itself has changed (because the code for the website hasn't changed).

@WebReflection
Copy link
Contributor

@ntoll I've no idea how to test any of this ... I don't know how to reproduce the issue, if you have a link to the current MR state that helps, otherwise please let me know how I can reproduce anything you are saying locally. The README is non-existent and I don't know how to test this MR at all, thanks!

@WebReflection
Copy link
Contributor

If I should copy and paste changed files somewhere that's fine too but I struggle to understand how MR lands in here ... I can test files manually though, still ... this repo needs some helping out for people not previously involved with it, imho.

@ntoll
Copy link
Member Author

ntoll commented Jun 10, 2024

My apologies... just run the website locally. Compare the "terminal" output with pyscript.net.

@WebReflection
Copy link
Contributor

I still think having a README or any other .md file that suggest how to test would be great but the issue was that we have a real REPL now that streams content back and forward from MicroPython so if we fake MicroPython output we better clean it up before processing the code as MicroPython will echo back whatever input it received before executing it and the terminal just shows it again.

I hope this explain the current fix ... we clean the line and return then MicroPython re-write the chars to parse and then executes these showing the result.

@ntoll
Copy link
Member Author

ntoll commented Jun 11, 2024

OK. Readme added. Will discuss changes in today's community call.

@ntoll ntoll changed the title Update to 2024.6.1 release. TODO: fix REPL. Update to 2024.6.1 release / add community link and README Jun 11, 2024
@ntoll ntoll marked this pull request as ready for review June 13, 2024 09:19
@ntoll
Copy link
Member Author

ntoll commented Jun 13, 2024

FWIW - @laffra just asked for this very (discord) feature. I'm gonna merge since lots of folks are asking for it.

@laffra
Copy link

laffra commented Jun 13, 2024

I had a few embarrassing moments at Goto Amsterdam when I wanted to point people to the Discord server to join the community. However, I could not find it anywhere 🤦

@ntoll ntoll merged commit 4249c06 into main Jun 13, 2024
@ntoll ntoll deleted the 2024-6-1 branch June 13, 2024 09:24
@laffra
Copy link

laffra commented Jun 13, 2024

This change causes Brave to go into an infinite refresh loop.

Uploading pyscript.net broken.mov…

@ntoll
Copy link
Member Author

ntoll commented Jun 13, 2024

After a moment, the Brave related problem went away. Putting this down to a weird Heisenbug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants