I'd recommend putting the checker into tox or pre-commit configs since those would have better cross-env integrations and aren't locked to just the CI.

@webknjaz that is a lot more work, since there is no easy way to "pip install" ec.

I'm not against this, this is just to at least get the ball rolling.

How would you approach this? Installing ec seamlessly into the tox environment?

It has a native integration with the pre-commit framework: https://github.com/editorconfig-checker/editorconfig-checker/blob/main/.pre-commit-hooks.yaml. So just add a .pre-commit-config.yaml pointing to the repo. Call pre-commit run --all-files in tox.ini and make sure you have a job calling that tox env in CI.

In my projects, it looks like this: https://github.com/ansible/awx-plugins/actions/runs/16881280962/job/47817646031.

Overall, having pre-commit invoked in CI through tox probably deserves a dedicated PR. Once it's in, adding any new linters and/or formatters would be going through the pre-commit framework and would work in CI, locally through tox and even if editor integrations somehow call pre-commit outside this infra.
Additionally, I recommend enabling https://pre-commit.ci in this repo to get a PR integration with formatting back-pushes.

Also, there's a wrapper that does work with pip install: https://pypi.org/p/editorconfig-checker. But I'd still go the pre-commit route. Though, maybe it's easier to use this in the scope of this PR until there's pre-commit based infra.

PS. I did this quick PR to ensure the authors would catch issues like putting tabs into places were the norm is spaces and I or others not to have to point it out.

PS. I did this quick PR to ensure the authors would catch issues like putting tabs into places were the norm is spaces and I or others not to have to point it out.

Then, I'd definitelly go for the pre-commit framework as it has native fixers for this sort of things: https://github.com/ansible/awx-plugins/blob/12091e4/.pre-commit-config.yaml#L65-L68. Check out https://pre-commit.com/hooks.html for more fun stuff.

@webknjaz I see, I get it; but @bluetech is going to have to authorize pre-commit.ci

Does it make sense to merge this in the interim, while we wait for the integration? Seems to me that the only thing we would remove is the changes to .github/workflows/main.yml -- everything else would stay in place. Plus, adding the hook config files.

What do you think?

This PR being a stop-gap.

@kingbuzzman I edited one of the previous comments with the pip install option if that works for you. Otherwise, whatever works for you 🤷‍♂️

is going to have to authorize pre-commit.ci

Note that his is a nice to have. Using it in GHA through tox isn't blocked as the GH App isn't needed for that. I'm rather surprised that there's no linting job in CI already.

Also, there's a wrapper that does work with pip install: pypi.org/p/editorconfig-checker. But I'd still go the pre-commit route. Though, maybe it's easier to use this in the scope of this PR until there's pre-commit based infra.

OH wow. I completely missed this! -- ok ok, let me patch it 😇

@webknjaz DOPE suggestions as always! Thank you so much!! ❤️

@kingbuzzman a note while pulling this into my PR: The new linting seems to freak out on pycache files in my local editor: tests/pycache/test_unittest.cpython-311-pytest-8.4.1.pyc:
Wrong line endings or no final newline
Not all lines have the correct end of line character
89-91: Trailing whitespace
119-123: Trailing whitespace
169-171: Trailing whitespace
194-195: Trailing whitespace
224-229: Trailing whitespace

Is it worth making an issue to manage exclusions, or may I be doing something wrong on my setup?

It should be fixed in the repo