Skip to content

Document RotatingFileHandler.shouldRollover() and TimedRotatingFileHandler.shouldRollover() #134817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AllenSH12 opened this issue May 28, 2025 · 0 comments
Closed

Document RotatingFileHandler.shouldRollover() and TimedRotatingFileHandler.shouldRollover() #134817

AllenSH12 opened this issue May 28, 2025 · 0 comments
Labels
docs Documentation in the Doc dir

Comments

@AllenSH12
Copy link
Contributor

AllenSH12 commented May 28, 2025 •
edited by bedevere-app bot
Loading

Documentation

The RotatingFileHandler and TimedRotatingFileHandler do not document the shouldRollover method that they both implement.

Linked PRs
@AllenSH12 AllenSH12 added the docs Documentation in the Doc dir label May 28, 2025
@bedevere-app bedevere-app bot mentioned this issue May 28, 2025
Merged
vsajip pushed a commit that referenced this issue May 28, 2025
@AllenSH12
gh-134817: Document [Timed]RotatingFileHandler shouldRollover method (G…
7be5916 
…H-134818)

Co-authored-by: Allen Hernandez <2349718+AllenSH12@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 28, 2025
@AllenSH12 @miss-islington
pythongh-134817: Document [Timed]RotatingFileHandler shouldRollover m…
7cf71e0 
…ethod (pythonGH-134818)

(cherry picked from commit 7be5916)

Co-authored-by: Allen Hernandez <AllenSH12@users.noreply.github.com>
Co-authored-by: Allen Hernandez <2349718+AllenSH12@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 28, 2025
@AllenSH12 @miss-islington
pythongh-134817: Document [Timed]RotatingFileHandler shouldRollover m…
19d87d7 
…ethod (pythonGH-134818)

(cherry picked from commit 7be5916)

Co-authored-by: Allen Hernandez <AllenSH12@users.noreply.github.com>
Co-authored-by: Allen Hernandez <2349718+AllenSH12@users.noreply.github.com>
This was referenced May 28, 2025
Merged
Merged
vsajip pushed a commit that referenced this issue May 28, 2025
@miss-islington
[3.13] gh-134817: Document [Timed]RotatingFileHandler shouldRollover …
8e60e6c 
…method (GH-134818) (GH-134824)

(cherry picked from commit 7be5916)
vsajip pushed a commit that referenced this issue May 28, 2025
@miss-islington
[3.14] gh-134817: Document [Timed]RotatingFileHandler shouldRollover …
7515384 
…method (GH-134818) (GH-134823)

(cherry picked from commit 7be5916)
@vsajip vsajip closed this as completed May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
docs issues
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vsajip @AllenSH12