Skip to content

(gh-134817) Documents [Timed]RotatingFileHandler shouldRollover method #134818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

(gh-134817) Documents [Timed]RotatingFileHandler shouldRollover method #134818

merged 1 commit into from
May 28, 2025

Conversation

AllenSH12
Copy link
Contributor

@AllenSH12 AllenSH12 commented May 28, 2025 •
edited by github-actions bot
Loading

@AllenSH12 AllenSH12 requested a review from vsajip as a code owner May 28, 2025 00:55
@python-cla-bot
Copy link

python-cla-bot bot commented May 28, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot mentioned this pull request May 28, 2025
Closed
@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels May 28, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs May 28, 2025
@AllenSH12 AllenSH12 force-pushed the docs/rotating-file-handlers branch from 3cbc934 to 3d696db Compare May 28, 2025 00:58
@AllenSH12 AllenSH12 changed the title (gh-134817) Documents RotatingFileHandler and TimedRotatingFileHandler shouldRoll… (gh-134817) Documents [Timed]RotatingFileHandler shouldRollover method May 28, 2025
@vsajip vsajip merged commit 7be5916 into python:main May 28, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs May 28, 2025
@vsajip vsajip added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 28, 2025
@miss-islington-app
Copy link

Thanks @AllenSH12 for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @AllenSH12 for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2025
@AllenSH12 @miss-islington
pythongh-134817: Document [Timed]RotatingFileHandler shouldRollover m…
7cf71e0 
…ethod (pythonGH-134818)

(cherry picked from commit 7be5916)

Co-authored-by: Allen Hernandez <AllenSH12@users.noreply.github.com>
Co-authored-by: Allen Hernandez <2349718+AllenSH12@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2025
@AllenSH12 @miss-islington
pythongh-134817: Document [Timed]RotatingFileHandler shouldRollover m…
19d87d7 
…ethod (pythonGH-134818)

(cherry picked from commit 7be5916)

Co-authored-by: Allen Hernandez <AllenSH12@users.noreply.github.com>
Co-authored-by: Allen Hernandez <2349718+AllenSH12@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented May 28, 2025

GH-134823 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 28, 2025
@bedevere-app
Copy link

bedevere-app bot commented May 28, 2025

GH-134824 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 28, 2025
@vsajip
Copy link
Member

vsajip commented May 28, 2025

@AllenSH12 Thanks for the patch - for some reason, the backport PRs don't appear to have registered your signature of the CLA (perhaps it relates to your email address). Could you please sign again so that the PRs for 3.13 and 3.14 can be merged? Thanks!

vsajip pushed a commit that referenced this pull request May 28, 2025
@miss-islington
[3.13] gh-134817: Document [Timed]RotatingFileHandler shouldRollover …
8e60e6c 
…method (GH-134818) (GH-134824)

(cherry picked from commit 7be5916)
vsajip pushed a commit that referenced this pull request May 28, 2025
@miss-islington
[3.14] gh-134817: Document [Timed]RotatingFileHandler shouldRollover …
7515384 
…method (GH-134818) (GH-134823)

(cherry picked from commit 7be5916)
@AllenSH12
Copy link
Contributor Author

You're welcome @vsajip

I see the backporting PRs have been merged now, guessing everything is good with the CLA?

@vsajip
Copy link
Member

vsajip commented May 28, 2025

Yes, I'd set them up to auto-merge once the block was removed, which you did by signing again, I guess 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip vsajip approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AllenSH12 @vsajip