Skip to content

gh-104374: Remove access to class scopes for inlined comprehensions #104528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 18, 2023
+125 −9
Merged

gh-104374: Remove access to class scopes for inlined comprehensions #104528

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3fad7b0
gh-104374: Remove access to class scopes for inlined comprehensions
JelleZijlstra May 16, 2023
fa11ca9
Update Lib/test/test_listcomps.py
JelleZijlstra May 16, 2023
1d776fd
Remove unnecessary change
JelleZijlstra May 16, 2023
932a2da
Better tests, copied from Carl's PR
JelleZijlstra May 16, 2023
d5653ae
A few more tests
JelleZijlstra May 16, 2023
ba3bacf
Merge remote-tracking branch 'upstream/main' into classcomp2
JelleZijlstra May 16, 2023
948bc1a
fix definition of 'in a class block'
carljm May 17, 2023
045478f
a couple more tests
carljm May 17, 2023
fc63272
Merge remote-tracking branch 'upstream/main' into classcomp2
JelleZijlstra May 18, 2023
afe0277
A few more tests
JelleZijlstra May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Lib/test/test_listcomps.py 
Co-authored-by: Carl Meyer <carl@oddbird.net>
  • Loading branch information
@JelleZijlstra @carljm
JelleZijlstra and carljm authored May 16, 2023
commit fa11ca9686457e0a33823f46b23c5266a622ff6b
2 changes: 1 addition & 1 deletion Lib/test/test_listcomps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ class X:
vals = X.vals
"""
self._check_in_scopes(code, {"vals": [(0, 1), (1, 1)]},
scopes=["module", "fucntion"])
scopes=["module", "function"])


__test__ = {'doctests' : doctests}
Expand Down