Skip to content

gh-114561: Mark some tests in test_wincosoleio with requires_resource('console') decorator #114565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2024
Merged

gh-114561: Mark some tests in test_wincosoleio with requires_resource('console') decorator #114565

merged 1 commit into from
Jan 25, 2024
+4 −1

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Jan 25, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 25, 2024
Closed
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Jan 25, 2024
@Eclips4

This comment was marked as outdated.

Sign in to view
@bedevere-bot

This comment was marked as outdated.

Sign in to view
@Eclips4
Copy link
Member Author

Eclips4 commented Jan 25, 2024

!buildbot AMD64 Windows10 PR

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @Eclips4 for commit 9eea72a 🤖

The command will test the builders whose names match following regular expression: AMD64 Windows10 PR

The builders matched are:

  • AMD64 Windows10 PR

@Eclips4 Eclips4 requested a review from zooba January 25, 2024 19:22
@Eclips4 Eclips4 added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 25, 2024
@zooba
Copy link
Member

zooba commented Jan 25, 2024

LGTM 👍

@zooba zooba merged commit 33ae989 into python:main Jan 25, 2024
@miss-islington-app
Copy link

Thanks @Eclips4 for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 25, 2024
@Eclips4 @miss-islington
pythongh-114561: Mark some tests in test_wincosoleio with `requir…
2ddb16f 
…es_resource('console')` decorator (pythonGH-114565)

(cherry picked from commit 33ae989)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 25, 2024
@Eclips4 @miss-islington
pythongh-114561: Mark some tests in test_wincosoleio with `requir…
684a620 
…es_resource('console')` decorator (pythonGH-114565)

(cherry picked from commit 33ae989)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@bedevere-app
Copy link

bedevere-app bot commented Jan 25, 2024

GH-114566 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jan 25, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jan 25, 2024

GH-114567 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Jan 25, 2024
@Eclips4 Eclips4 deleted the issue-114561 branch January 25, 2024 20:06
zooba pushed a commit that referenced this pull request Jan 25, 2024
@miss-islington @Eclips4
gh-114561: Mark some tests in test_wincosoleio with `requires_resou…
8cff807 
…rce('console')` decorator (GH-114565)

(cherry picked from commit 33ae989)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
zooba pushed a commit that referenced this pull request Jan 25, 2024
@miss-islington @Eclips4
gh-114561: Mark some tests in test_wincosoleio with `requires_resou…
4ff2d29 
…rce('console')` decorator (GH-114565)

(cherry picked from commit 33ae989)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@Eclips4 Eclips4 mentioned this pull request Jan 27, 2024
Closed
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@Eclips4 @aisk
pythongh-114561: Mark some tests in test_wincosoleio with `requir…
2138901 
…es_resource('console')` decorator (pythonGH-114565)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@Eclips4 @Glyphack
pythongh-114561: Mark some tests in test_wincosoleio with `requir…
8a2090f 
…es_resource('console')` decorator (pythonGH-114565)
This was referenced May 6, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba Awaiting requested review from zooba

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eclips4 @bedevere-bot @zooba