Skip to content

[3.12] GH-117894: prevent aclose()/athrow() being re-used after StopIteration (GH-117851) #118226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Apr 24, 2024

(cherry picked from commit 7d369d4)

@encukou
Copy link
Member

encukou commented Apr 24, 2024

Why not backport the test_aclose_throw test as well?

@graingert
Copy link
Contributor Author

graingert commented Apr 24, 2024

Why not backport the test_aclose_throw test as well?

That's in the test class TestUnawaitedWarnings that only applies to 3.13+

test_aclose_throw is a regression test so it would pass on 3.12 but I don't think it's necessary to backport it

@graingert graingert requested a review from encukou April 24, 2024 15:36
@encukou encukou merged commit fc1732c into python:3.12 Apr 25, 2024
28 checks passed
@graingert graingert deleted the backport-7d369d4-3.12 branch April 25, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants