Skip to content

gh-121662: Fix PyREPL on UNIX with non-blocking stdin #121689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

IljaManakov
Copy link

@IljaManakov IljaManakov commented Jul 13, 2024

@ghost
Copy link

ghost commented Jul 13, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Jul 13, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@IljaManakov IljaManakov force-pushed the fix-pyrepl-non-blocking-stdin branch from f17605e to 4beacac Compare July 13, 2024 13:11
@bedevere-app
Copy link

bedevere-app bot commented Jul 13, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@IljaManakov IljaManakov force-pushed the fix-pyrepl-non-blocking-stdin branch from 4beacac to b86716d Compare July 13, 2024 13:12
@bedevere-app
Copy link

bedevere-app bot commented Jul 13, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

1 similar comment
@bedevere-app
Copy link

bedevere-app bot commented Jul 13, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@IljaManakov IljaManakov force-pushed the fix-pyrepl-non-blocking-stdin branch from 89ec6da to d59b461 Compare July 13, 2024 13:56
@bedevere-app
Copy link

bedevere-app bot commented Jul 13, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

1 similar comment
@bedevere-app
Copy link

bedevere-app bot commented Jul 13, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@IljaManakov IljaManakov force-pushed the fix-pyrepl-non-blocking-stdin branch from 424e823 to bbc8377 Compare July 13, 2024 14:00
@bedevere-app
Copy link

bedevere-app bot commented Jul 13, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

1 similar comment
@bedevere-app
Copy link

bedevere-app bot commented Jul 13, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@IljaManakov IljaManakov force-pushed the fix-pyrepl-non-blocking-stdin branch from b7ab5f0 to 5c71fad Compare July 13, 2024 14:37
@ambv
Copy link
Contributor

ambv commented Jul 13, 2024

With the current suggestions we will only check for blocking once per line, which is more efficient.

Also, don't force push to your branch. Just add new commits. That makes reviewing easier.

@IljaManakov IljaManakov requested a review from ambv July 14, 2024 09:41
@python-cla-bot
Copy link

The following commit authors need to sign the Contributor License Agreement:

CLA signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants