Generalize reusable Windows CI jobs #121766
Merged
+41
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, GitHub Actions turn things into strings when passing the data around. So it's usually safer to turn them into proper booleans in expressions explicitly.
Previously, it didn't have a human-readable explanation which is a bad tone as it's less obvious how it's supposed to be used.
Previously, it was duplicated in each job which is not DRY.
d97631c to
2a92204
Compare
Previously, the reusable windows workflow defined a number of per-arch jobs with a lot of copy-paste. Now, there is a single job and a matrix definition on the calling side.
Previously, these were defined through two separate matrices but there is no technical reason to keep them like that.
2a92204 to
21a36a2
Compare
|
Thanks for the PR. A quick note for myself, will come back to review properly later: So before, the Windows jobs showed up in the big misc box at the bottom (marked in yellow): 
https://github.com/python/cpython/actions/runs/9929374848 With this PR, they're in their own Windows box: 
|
hugovk
approved these changes
Jul 14, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 14, 2024
(cherry picked from commit 7982363) Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk@sydorenko.org.ua>
|
Sorry, @webknjaz and @hugovk, I could not cleanly backport this to |
|
GH-121775 is a backport of this pull request to the 3.13 branch. |
|
Extra note: one job name changed from |
hugovk
pushed a commit
that referenced
this pull request
Jul 14, 2024
|
GH-121776 is a backport of this pull request to the 3.12 branch. |
Manual backport: #121776 |
webknjaz
added a commit
to webknjaz/cpython
that referenced
this pull request
Jul 14, 2024
(cherry picked from commit 7982363)
FTR, this happens because of a weird corner case in GHA. Basically, it renders some of the job group representations differently depending on whether there's interpolation syntax in |
webknjaz
added a commit
to webknjaz/cpython
that referenced
this pull request
Jul 14, 2024
(cherry picked from commit 7982363)
|
@webknjaz This PR can't be merged: https://github.com/python/cpython/actions/runs/9950331379/job/27488343862?pr=121831
Do you know what is needed? |
webknjaz
added a commit
to webknjaz/cpython
that referenced
this pull request
Jul 16, 2024
Previously, those flags would sometimes end up having empty string
values which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.
This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry.
This should help make PRs like python#121831 mergeable again.
[1]: python#121766 (comment)
webknjaz
added a commit
to webknjaz/cpython
that referenced
this pull request
Jul 16, 2024
Previously, those flags would sometimes end up having empty string
values which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.
This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].
This should help make PRs like python#121831 mergeable again.
[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
webknjaz
added a commit
to webknjaz/cpython
that referenced
this pull request
Jul 16, 2024
Previously, those flags would sometimes end up having empty string
values, which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.
This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].
This should help make PRs like python#121831 mergeable again.
[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
webknjaz
added a commit
to webknjaz/cpython
that referenced
this pull request
Jul 16, 2024
Previously, those flags would sometimes end up having empty string
values, which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.
This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].
This should help make PRs like python#121831 mergeable again.
[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
webknjaz
added a commit
to webknjaz/cpython
that referenced
this pull request
Jul 16, 2024
Previously, those flags would sometimes end up having empty string
values, which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.
This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].
This should help make PRs like python#121831 mergeable again.
[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
Back-referencing the possible fix: #121848 |
webknjaz
added a commit
to webknjaz/cpython
that referenced
this pull request
Jul 16, 2024
(cherry picked from commit 7982363)
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
hugovk
pushed a commit
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, both the reusable and calling workflows had a lot of unnecessary duplication in the windows job definitions. This patch simplifies that into a single parametrized job that is included though a matrix in different modes.