Skip to content

Ensure clang++ is autodetected on iOS. #123749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2024
Merged

Ensure clang++ is autodetected on iOS. #123749

merged 1 commit into from
Sep 6, 2024

Conversation

freakboy3742
Copy link
Contributor

#123620 added shims for clang++ on iOS; however, those shims won't be autodetected without an update to the configure script.

@freakboy3742 freakboy3742 added skip issue skip news 3.13 bugs and security fixes OS-ios 3.14 bugs and security fixes needs backport to 3.13 bugs and security fixes labels Sep 5, 2024
@freakboy3742
Copy link
Contributor Author

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 63e50e1 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

ned-deily
ned-deily approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ned-deily ned-deily merged commit d359c7c into python:main Sep 6, 2024
45 checks passed
@miss-islington-app
Copy link

Thanks @freakboy3742 for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 6, 2024
@freakboy3742 @miss-islington
Ensure clang++ is autodetected on iOS. (pythongh-123749)
c3bc817 
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 6, 2024

GH-123758 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 6, 2024
@freakboy3742 freakboy3742 deleted the cxx-autodetect branch September 6, 2024 02:13
freakboy3742 added a commit that referenced this pull request Sep 6, 2024
@miss-islington @freakboy3742
[3.13] Ensure clang++ is autodetected on iOS. (gh-123749) (#123758)
8ed77c1 
Ensure clang++ is autodetected on iOS. (gh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 6, 2024
@miss-islington @freakboy3742
[3.12] Ensure clang++ is autodetected on iOS. (pythongh-123749) (pyth…
7c0b6d5 
…on#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 6, 2024
@miss-islington @freakboy3742
[3.11] Ensure clang++ is autodetected on iOS. (pythongh-123749) (pyth…
5623e28 
…on#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 6, 2024
@miss-islington @freakboy3742
[3.10] Ensure clang++ is autodetected on iOS. (pythongh-123749) (pyth…
6b21c50 
…on#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 6, 2024
@miss-islington @freakboy3742
[3.9] Ensure clang++ is autodetected on iOS. (pythongh-123749) (pytho…
0a4cbfb 
…n#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
@encukou
Copy link
Member

encukou commented Sep 6, 2024

Process nitpick: In the future, please don't use skip issue for PRs that might need backports. The issue number is how related PRs get grouped together.

freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 9, 2024
@miss-islington @freakboy3742
[3.12] Ensure clang++ is autodetected on iOS. (pythongh-123749) (pyth…
71e76a9 
…on#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 9, 2024
@miss-islington @freakboy3742
[3.11] Ensure clang++ is autodetected on iOS. (pythongh-123749) (pyth…
014f291 
…on#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 9, 2024
@miss-islington @freakboy3742
[3.10] Ensure clang++ is autodetected on iOS. (pythongh-123749) (pyth…
6232238 
…on#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 9, 2024
@miss-islington @freakboy3742
[3.9] Ensure clang++ is autodetected on iOS. (pythongh-123749) (pytho…
71f7f63 
…n#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Oct 9, 2024
@miss-islington @freakboy3742
[3.12] Ensure clang++ is autodetected on iOS. (pythongh-123749) (pyth…
2618bb4 
…on#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Dec 13, 2024
@miss-islington @freakboy3742
[3.9] Ensure clang++ is autodetected on iOS. (pythongh-123749) (pytho…
71f6e84 
…n#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Dec 13, 2024
@miss-islington @freakboy3742
[3.10] Ensure clang++ is autodetected on iOS. (pythongh-123749) (pyth…
8e0d245 
…on#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Dec 13, 2024
@miss-islington @freakboy3742
[3.12] Ensure clang++ is autodetected on iOS. (pythongh-123749) (pyth…
89a9c81 
…on#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Dec 13, 2024
@miss-islington @freakboy3742
[3.11] Ensure clang++ is autodetected on iOS. (pythongh-123749) (pyth…
b996ad8 
…on#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily ned-deily approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees
No one assigned
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes OS-ios skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@freakboy3742 @bedevere-bot @encukou @ned-deily