[3.13] Add zizmor to pre-commit and fix most findings (#127749) #127786
Conversation
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> (cherry picked from commit ae31df3)
|
Looks like you might need to add |
|
No, JIT/Windows is also failing in a clean 3.13 branch: https://github.com/hugovk/cpython/actions/runs/12255332851/job/34188652334 And the changes in cc @brandtbucher FYI |
|
Ah, thanks, I should have looked more closely! |
|
I think the Windows failures in #127788 might be related, however? The error message there is different |
| - name: Build CPython installer | ||
| run: .\Tools\msi\build.bat --doc -${{ inputs.arch }} | ||
| run: .\Tools\msi\build.bat --doc -"${ARCH}" |
There was a problem hiding this comment.
this probably should also have been
| run: .\Tools\msi\build.bat --doc -"${ARCH}" | |
| run: .\Tools\msi\build.bat --doc -"${ARCH}" | |
| shell: bash |
maybe this job doesn't run on PRs?
There was a problem hiding this comment.
There was a problem hiding this comment.
hmmm... are we absolutely confident that the environment variable was properly expanded as part of the command that successfully ran in that workflow?
There was a problem hiding this comment.
Let's double check. Just heading out to Helsinki Python, I can check tomorrow if no-one beats me to it!
Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com
(cherry picked from commit ae31df3)