CI: Use bash to properly expand variable #127822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezio-melotti
approved these changes
Dec 11, 2024
| @@ -24,4 +24,5 @@ jobs: | |||
| with: | |||
| persist-credentials: false | |||
| - name: Build CPython installer | |||
| run: .\Tools\msi\build.bat --doc -"${ARCH}" | |||
| run: ./Tools/msi/build.bat --doc -"${ARCH}" | |||
There was a problem hiding this comment.
It seems that with shell: bash both / and \\ work for paths, but not \.
I've seen (and used) \\ elsewhere, but since this is the only instance in this file and / is more readable we don't need to worry about consistency here.
There was a problem hiding this comment.
Yes, / and \\ are both valid path separators on Windows, so using / always works fine for paths on Windows. The difference between the platforms is that / is not the default path separator on Windows.
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 11, 2024
(cherry picked from commit b2ad7e0) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-127824 is a backport of this pull request to the 3.13 branch. |
AlexWaygood
pushed a commit
that referenced
this pull request
Dec 11, 2024
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #127749.
Re: #127786 (comment).
Needs backporting to 3.13 but was already added to 3.12 in #127788.