Skip to content

[3.13] gh-129539: Include sysexits.h before checking EX_OK #129590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2025
Merged

[3.13] gh-129539: Include sysexits.h before checking EX_OK #129590

merged 1 commit into from
Feb 2, 2025
+5 −4

Conversation

collinfunk
Copy link
Contributor

@collinfunk collinfunk commented Feb 2, 2025 •
edited by bedevere-app bot
Loading

@collinfunk
pythongh-129539: Include sysexits.h before checking EX_OK
2fdfee1 
Previously the macro would be redefined when the header was included.
@bedevere-app bedevere-app bot mentioned this pull request Feb 2, 2025
Closed
@vstinner vstinner changed the title [3.13] Include sysexits.h before checking EX_OK (GH-129540) [3.13] gh-129540: Include sysexits.h before checking EX_OK (GH-129540) Feb 2, 2025
@vstinner vstinner changed the title [3.13] gh-129540: Include sysexits.h before checking EX_OK (GH-129540) [3.13] gh-129540: Include sysexits.h before checking EX_OK Feb 2, 2025
@vstinner vstinner changed the title [3.13] gh-129540: Include sysexits.h before checking EX_OK [3.13] gh-129539: Include sysexits.h before checking EX_OK Feb 2, 2025
@bedevere-app bedevere-app bot mentioned this pull request Feb 2, 2025
Closed
@vstinner vstinner merged commit 65f3432 into python:3.13 Feb 2, 2025
38 checks passed
@vstinner vstinner added the needs backport to 3.12 only security fixes label Feb 2, 2025
@miss-islington-app
Copy link

Thanks @collinfunk for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @collinfunk and @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 65f3432ac32f92bc3d8b7b11103a56c5a70049c0 3.12

@bedevere-app
Copy link

bedevere-app bot commented Feb 3, 2025

GH-129609 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 3, 2025
vstinner added a commit that referenced this pull request Feb 3, 2025
@vstinner @collinfunk
[3.12] gh-129539: Include sysexits.h before checking EX_OK (#129590) (#…
6186021 
…129609)

[3.13] gh-129539: Include sysexits.h before checking EX_OK (#129590)

Previously, the macro would be redefined when the header was included.

(cherry picked from commit 65f3432)

Co-authored-by: Collin Funk <collin.funk1@gmail.com>
@collinfunk collinfunk deleted the sysexits-redefinition-3.13 branch February 3, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vstinner vstinner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@collinfunk @vstinner