Skip to content

bpo-36742: Fixes handling of pre-normalization characters in urlsplit() #13017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2019
Merged

bpo-36742: Fixes handling of pre-normalization characters in urlsplit() #13017

merged 2 commits into from
Apr 30, 2019

Conversation

zooba
Copy link
Member

@zooba zooba commented Apr 29, 2019 •
edited by bedevere-bot
Loading

eamanu
eamanu approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I test it in a Debian 4.9.168-1 x86_64 GNU/Linux and the bugs is fixed.

Tests run ok.

@zooba zooba merged commit d537ab0 into python:master Apr 30, 2019
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@zooba zooba deleted the bpo-36742 branch April 30, 2019 12:03
@bedevere-bot
Copy link

GH-13023 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 30, 2019
@zooba @miss-islington
bpo-36742: Fixes handling of pre-normalization characters in urlsplit…
781ffb1 
…() (pythonGH-13017)

(cherry picked from commit d537ab0)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 30, 2019
@zooba @miss-islington
bpo-36742: Fixes handling of pre-normalization characters in urlsplit…
e3dc36c 
…() (pythonGH-13017)

(cherry picked from commit d537ab0)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

GH-13024 is a backport of this pull request to the 3.6 branch.

@miss-islington
Copy link
Contributor

Sorry, @zooba, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d537ab0ff9767ef024f26246899728f0116b1ec3 2.7

@bedevere-bot
Copy link

GH-13025 is a backport of this pull request to the 2.7 branch.

miss-islington added a commit that referenced this pull request Apr 30, 2019
@miss-islington @zooba
bpo-36742: Fixes handling of pre-normalization characters in urlsplit…
4d723e7 
…() (GH-13017)

(cherry picked from commit d537ab0)

Co-authored-by: Steve Dower <steve.dower@python.org>
zooba added a commit that referenced this pull request May 1, 2019
@zooba
bpo-36742: Fixes handling of pre-normalization characters in urlsplit…
98a4dce 
…() (GH-13017)
zooba added a commit to zooba/cpython that referenced this pull request May 1, 2019
@zooba
bpo-36742: Fixes handling of pre-normalization characters in urlsplit…
2bce86b 
…() (pythonGH-13017)
ned-deily pushed a commit that referenced this pull request May 2, 2019
@miss-islington @zooba @ned-deily
bpo-36742: Fixes handling of pre-normalization characters in urlsplit…
e5f9f4a 
…() (GH-13017) (GH-13024)

(cherry picked from commit d537ab0)

Co-authored-by: Steve Dower <steve.dower@python.org>
larryhastings pushed a commit that referenced this pull request Jul 14, 2019
@zooba @larryhastings
bpo-36742: Fixes handling of pre-normalization characters in urlsplit…
4655d57 
…() (GH-13017) (#13042)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamanu eamanu eamanu approved these changes

Assignees

@zooba zooba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zooba @miss-islington @bedevere-bot @eamanu @the-knights-who-say-ni