[2.7] bpo-36742: Fixes handling of pre-normalization characters in urlsplit() (GH-13017) #13025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirkarthi
reviewed
Apr 30, 2019
Lib/test/test_urlparse.py
Outdated
| @@ -641,6 +641,12 @@ def test_urlsplit_normalization(self): | |||
| self.assertIn(u'\u2100', denorm_chars) | |||
| self.assertIn(u'\uFF03', denorm_chars) | |||
|
|
|||
| # bpo-36742: Verify port separators are ignored when they | |||
| # existed prior to decomposition | |||
| urllib.parse.urlsplit('http://\u30d5\u309a:80') | |||
There was a problem hiding this comment.
I guess the Python 3 patch applied here. urlunparse.urlsplit could be the correct function for this test.
There was a problem hiding this comment.
You're welcome. There is some test error on CI :
test test_urlparse failed -- Traceback (most recent call last):
File "/home/travis/build/python/cpython/Lib/test/test_urlparse.py", line 648, in test_urlsplit_normalization
urlparse.urlsplit('http://\u30d5\u309a\ufe1380')
AssertionError: ValueError not raised
There was a problem hiding this comment.
Ah I guess u"" prefix is missing since it's Python 2 ? Adding it makes the tests to pass locally for the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36742