-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-130655: Increase test coverage of gettext._expand_lang
#130656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Thanks @tomasr8 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…thonGH-130656) (cherry picked from commit 24c52cb) Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
GH-130671 is a backport of this pull request to the 3.13 branch. |
…thonGH-130656) (cherry picked from commit 24c52cb) Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
GH-130672 is a backport of this pull request to the 3.12 branch. |
This will help with properly testing
gettext.find
which calls_expand_lang
.With these tests, the function is fully covered:
gettext
#130655