Skip to content

gh-130655: Increase test coverage of gettext._expand_lang #130656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Feb 27, 2025

This will help with properly testing gettext.find which calls _expand_lang.

With these tests, the function is fully covered:

obrazek

@tomasr8 tomasr8 added tests Tests in the Lib/test dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 27, 2025
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka merged commit 24c52cb into python:main Feb 28, 2025
52 checks passed
@miss-islington-app
Copy link

Thanks @tomasr8 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 28, 2025
…thonGH-130656)

(cherry picked from commit 24c52cb)

Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 28, 2025

GH-130671 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 28, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 28, 2025
…thonGH-130656)

(cherry picked from commit 24c52cb)

Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 28, 2025

GH-130672 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 28, 2025
@tomasr8 tomasr8 deleted the gettext-expand-lang branch February 28, 2025 08:44
serhiy-storchaka pushed a commit that referenced this pull request Feb 28, 2025
…H-130656) (GH-130672)

(cherry picked from commit 24c52cb)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull request Feb 28, 2025
…H-130656) (GH-130671)

(cherry picked from commit 24c52cb)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants