Skip to content

gh-132742: Fix newly added tcflush() tests on Android #133070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2025
Merged

gh-132742: Fix newly added tcflush() tests on Android #133070

merged 3 commits into from
Apr 28, 2025

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Apr 28, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added awaiting core review tests Tests in the Lib/test dir labels Apr 28, 2025
@serhiy-storchaka
Copy link
Member Author

!builtbot android

@bedevere-app bedevere-app bot mentioned this pull request Apr 28, 2025
Closed
@serhiy-storchaka serhiy-storchaka changed the title gh-132742: Fix tcflush() tests on Android gh-132742: Fix newly added tcflush() tests on Android Apr 28, 2025
@serhiy-storchaka serhiy-storchaka mentioned this pull request Apr 28, 2025
Merged
@serhiy-storchaka
Copy link
Member Author

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 777da5b 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133070%2Fmerge

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

@serhiy-storchaka
Copy link
Member Author

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 58c2e60 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133070%2Fmerge

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

@serhiy-storchaka
Copy link
Member Author

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 3642a32 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133070%2Fmerge

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

vstinner
vstinner reviewed Apr 28, 2025
View reviewed changes
Lib/test/test_ioctl.py Outdated
@@ -173,20 +176,22 @@ def test_ioctl_suspend_and_resume_output(self):

def writer():
os.write(wfd, b'abc')
write_suspended.wait()
self.assertTrue(write_suspended.wait(5))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to use support.SHORT_TIMEOUT rather than hardcoded timeout. Same remark for other 5 seconds timeouts.

@serhiy-storchaka
Copy link
Member Author

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit c3a0c3d 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133070%2Fmerge

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

@serhiy-storchaka serhiy-storchaka merged commit 25186c2 into python:main Apr 28, 2025
40 checks passed
@serhiy-storchaka serhiy-storchaka deleted the test-ioctl5 branch April 28, 2025 18:41
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.13 bugs and security fixes label Apr 28, 2025
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 28, 2025
@serhiy-storchaka @miss-islington
pythongh-132742: Fix newly added tcflush() tests on Android (pythonGH…
afa07ba 
…-133070)

(cherry picked from commit 25186c2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Apr 28, 2025

GH-133104 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 28, 2025
serhiy-storchaka added a commit that referenced this pull request Apr 28, 2025
@miss-islington @serhiy-storchaka
[3.13] gh-132742: Fix newly added tcflush() tests on Android (GH-133070…
b71442f 
…) (GH-133104)

(cherry picked from commit 25186c2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serhiy-storchaka @bedevere-bot @vstinner