gh-132742: Fix newly added tcflush() tests on Android #133070
Conversation
serhiy-storchaka
commented
Apr 28, 2025
•
- Issue: Rewrite the fcntl module #132742
|
!builtbot android |
|
!buildbot android |
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 777da5b 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133070%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
fd8293f to
58c2e60
Compare
|
!buildbot android |
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 58c2e60 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133070%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
58c2e60 to
f2bba60
Compare
f2bba60 to
3642a32
Compare
|
!buildbot android |
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 3642a32 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133070%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Lib/test/test_ioctl.py
Outdated
| @@ -173,20 +176,22 @@ def test_ioctl_suspend_and_resume_output(self): | |||
|
|
|||
| def writer(): | |||
| os.write(wfd, b'abc') | |||
| write_suspended.wait() | |||
| self.assertTrue(write_suspended.wait(5)) | |||
There was a problem hiding this comment.
I would prefer to use support.SHORT_TIMEOUT rather than hardcoded timeout. Same remark for other 5 seconds timeouts.
|
!buildbot android |
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit c3a0c3d 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133070%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
GH-133104 is a backport of this pull request to the 3.13 branch. |