Skip to content

gh-132987: Support __index__() in the select.kqueue_event constructor #133094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Apr 28, 2025

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just have a minor suggestion on the error message.

Co-authored-by: Victor Stinner <vstinner@python.org>
@serhiy-storchaka
Copy link
Member Author

I afraid that when we will add more convenient general converters, the error message will be changed to something like "unsigned 32-bit integer" or "unsigned 64-bit integer" (depending on platform).

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) April 29, 2025 13:33
@serhiy-storchaka serhiy-storchaka merged commit d2d4900 into python:main Apr 29, 2025
41 checks passed
@serhiy-storchaka serhiy-storchaka deleted the select-unsigned-int-index branch April 29, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants