gh-133196: Guard PEP 750 grammar with `CHECK_VERSION` #133225

sobolevn · 2025-04-30T22:00:04Z

No news, because this was never released.

Issue: PEP 750 changes do no guard for usage with older versions like ast.parse(t'', feature_version=(3, 13)) #133196

lysnikolaou

LGTM! Thanks @sobolevn!

bedevere-bot · 2025-05-01T07:30:15Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable Clang 3.x (tier-2) has failed when building commit 5cdd49b.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/234/builds/7554) and take a look at the build logs.
Check if the failure is related to this commit (5cdd49b) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/234/builds/7554

Failed tests:

test_functools

Summary of the results of the build (if available):

==

Click to see traceback logs

remote: Enumerating objects: 10, done.        
remote: Counting objects:  25% (1/4)        
remote: Counting objects:  50% (2/4)        
remote: Counting objects:  75% (3/4)        
remote: Counting objects: 100% (4/4)        
remote: Counting objects: 100% (4/4), done.        
remote: Compressing objects:  25% (1/4)        
remote: Compressing objects:  50% (2/4)        
remote: Compressing objects:  75% (3/4)        
remote: Compressing objects: 100% (4/4)        
remote: Compressing objects: 100% (4/4), done.        
remote: Total 10 (delta 0), reused 0 (delta 0), pack-reused 6 (from 1)        
From https://github.com/python/cpython
 * branch                    main       -> FETCH_HEAD
Note: switching to '5cdd49b3f4cbdcf0472a65fd0c723912c3d48211'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 5cdd49b3f4c gh-133196: Guard PEP 750 grammar with `CHECK_VERSION` (#133225)
Switched to and reset branch 'main'

make: *** [Makefile:2453: buildbottest] Error 2

bedevere-bot · 2025-05-01T07:40:10Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL8 LTO + PGO 3.x (tier-2) has failed when building commit 5cdd49b.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/78/builds/9032) and take a look at the build logs.
Check if the failure is related to this commit (5cdd49b) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/78/builds/9032

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 10, done.        
remote: Counting objects:  25% (1/4)        
remote: Counting objects:  50% (2/4)        
remote: Counting objects:  75% (3/4)        
remote: Counting objects: 100% (4/4)        
remote: Counting objects: 100% (4/4), done.        
remote: Compressing objects:  25% (1/4)        
remote: Compressing objects:  50% (2/4)        
remote: Compressing objects:  75% (3/4)        
remote: Compressing objects: 100% (4/4)        
remote: Compressing objects: 100% (4/4), done.        
remote: Total 10 (delta 0), reused 0 (delta 0), pack-reused 6 (from 1)        
From https://github.com/python/cpython
 * branch                    main       -> FETCH_HEAD
Note: switching to '5cdd49b3f4cbdcf0472a65fd0c723912c3d48211'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 5cdd49b3f4c gh-133196: Guard PEP 750 grammar with `CHECK_VERSION` (#133225)
Switched to and reset branch 'main'

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make[2]: [Makefile:3339: clean-retain-profile] Error 1 (ignored)
./Modules/_testlimitedcapi/unicode.c: In function ‘test_string_from_format’:
./Modules/_testlimitedcapi/unicode.c:1416:1: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 test_string_from_format(PyObject *self, PyObject *Py_UNUSED(ignored))
 ^~~~~~~~~~~~~~~~~~~~~~~
./Modules/_testlimitedcapi/unicode.c: In function ‘test_string_from_format’:
./Modules/_testlimitedcapi/unicode.c:1416:1: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 test_string_from_format(PyObject *self, PyObject *Py_UNUSED(ignored))
 ^
Python/Python-ast.c: In function ‘init_types’:
Python/Python-ast.c:6137:1: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 init_types(void *arg)
 ^~~~~~~~~~
Python/Python-ast.c: In function ‘init_types’:
Python/Python-ast.c:6137:1: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 init_types(void *arg)
 ^
Python/Python-ast.c: In function ‘init_types’:
Python/Python-ast.c:6137:1: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 init_types(void *arg)
 ^
Python/Python-ast.c: In function ‘init_types’:
Python/Python-ast.c:6137:1: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 init_types(void *arg)
 ^
Fatal Python error: Segmentation fault

Current thread 0x0000fffface14590 [python] (most recent call first):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/test_functools.py", line 420 in test_recursive_pickle
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/unittest/case.py", line 615 in _callTestMethod
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/unittest/case.py", line 669 in run
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/unittest/case.py", line 725 in __call__
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/libregrtest/testresult.py", line 148 in run
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/libregrtest/single.py", line 84 in _run_suite
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/libregrtest/single.py", line 42 in run_unittest
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/libregrtest/single.py", line 162 in test_func
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/libregrtest/single.py", line 118 in regrtest_runner
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/libregrtest/single.py", line 165 in _load_run_test
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/libregrtest/single.py", line 210 in _runtest_env_changed_exc
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/libregrtest/single.py", line 319 in _runtest
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/libregrtest/single.py", line 348 in run_single_test
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/libregrtest/main.py", line 389 in run_test
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/libregrtest/main.py", line 419 in run_tests_sequentially
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/libregrtest/main.py", line 561 in _run_tests
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/libregrtest/main.py", line 596 in run_tests
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/libregrtest/main.py", line 768 in main
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/libregrtest/main.py", line 776 in main
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/__main__.py", line 2 in <module>
  File "<frozen runpy>", line 88 in _run_code
  File "<frozen runpy>", line 198 in _run_module_as_main

Current thread's C stack trace (most recent call first):
  Binary file "./python", at _Py_DumpStack+0xd0 [0x5c4e50]
  Binary file "./python" [0x5c54a8]
  Binary file "linux-vdso.so.1", at __kernel_rt_sigreturn+0x0 [0xffffacdc07a0]
  Binary file "./python" [0xa885b8]
  Binary file "./python", at _Py_Dealloc+0x18c [0x96bb6c]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x29260 [0xffff9f3d9260]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x20410 [0xffff9f3d0410]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x2ab18 [0xffff9f3dab18]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x21e54 [0xffff9f3d1e54]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x1da64 [0xffff9f3cda64]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x203e4 [0xffff9f3d03e4]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x2ab18 [0xffff9f3dab18]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x21e54 [0xffff9f3d1e54]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x1da64 [0xffff9f3cda64]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x203e4 [0xffff9f3d03e4]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x2ab18 [0xffff9f3dab18]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x21e54 [0xffff9f3d1e54]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x1da64 [0xffff9f3cda64]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x203e4 [0xffff9f3d03e4]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x2ab18 [0xffff9f3dab18]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x21e54 [0xffff9f3d1e54]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x1da64 [0xffff9f3cda64]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x203e4 [0xffff9f3d03e4]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x2ab18 [0xffff9f3dab18]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x21e54 [0xffff9f3d1e54]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x1da64 [0xffff9f3cda64]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x203e4 [0xffff9f3d03e4]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x2ab18 [0xffff9f3dab18]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x21e54 [0xffff9f3d1e54]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x1da64 [0xffff9f3cda64]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x203e4 [0xffff9f3d03e4]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/build/lib.linux-aarch64-3.14/_pickle.cpython-314-aarch64-linux-gnu.so", at +0x2ab18 [0xffff9f3dab18]
  <truncated rest of calls>

Extension modules: _testinternalcapi, _testcapi, _testlimitedcapi (total: 3)
make: *** [Makefile:1019: profile-run-stamp] Segmentation fault (core dumped)

pythongh-133196: Guard PEP 750 grammar with CHECK_VERSION

bf5b0fa

sobolevn added the skip news label Apr 30, 2025

sobolevn requested review from Eclips4, pablogsal and lysnikolaou as code owners April 30, 2025 22:00

bedevere-app bot added the awaiting core review label Apr 30, 2025

bedevere-app bot mentioned this pull request Apr 30, 2025

PEP 750 changes do no guard for usage with older versions like ast.parse(t'', feature_version=(3, 13)) #133196

Closed

lysnikolaou approved these changes May 1, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting core review labels May 1, 2025

lysnikolaou merged commit 5cdd49b into python:main May 1, 2025
49 checks passed

bedevere-app bot removed the awaiting merge label May 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-133196: Guard PEP 750 grammar with `CHECK_VERSION` #133225

gh-133196: Guard PEP 750 grammar with `CHECK_VERSION` #133225

sobolevn commented Apr 30, 2025 •

edited by bedevere-app bot

Loading

lysnikolaou left a comment

bedevere-bot commented May 1, 2025

bedevere-bot commented May 1, 2025

gh-133196: Guard PEP 750 grammar with CHECK_VERSION #133225

gh-133196: Guard PEP 750 grammar with CHECK_VERSION #133225

Conversation

sobolevn commented Apr 30, 2025 • edited by bedevere-app bot Loading

lysnikolaou left a comment

Choose a reason for hiding this comment

bedevere-bot commented May 1, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented May 1, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

gh-133196: Guard PEP 750 grammar with `CHECK_VERSION` #133225

gh-133196: Guard PEP 750 grammar with `CHECK_VERSION` #133225

sobolevn commented Apr 30, 2025 •

edited by bedevere-app bot

Loading