Skip to content

gh-132983: Remove pyzstd in identifiers #133535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-132983: Remove pyzstd in identifiers #133535

wants to merge 3 commits into from
+14 −27

Conversation

Rogdham
Copy link
Contributor

@Rogdham Rogdham commented May 6, 2025 •
edited by bedevere-app bot
Loading

The _PyZstd_xxx extern functions were leftover artifacts of the move from pyzstd to cpython.

I have renamed them to the _zstd_xxx convention used for private functions.

@python-cla-bot
Copy link

python-cla-bot bot commented May 6, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot mentioned this pull request May 6, 2025
Open
11 tasks
@Rogdham Rogdham marked this pull request as ready for review May 6, 2025 20:04
@Rogdham
Copy link
Contributor Author

Rogdham commented May 6, 2025

Thanks @emmatyping for the explanation about the context, pinging you for review as suggested 🤗

@ZeroIntensity ZeroIntensity requested a review from emmatyping May 6, 2025 20:56
emmatyping
emmatyping reviewed May 7, 2025
View reviewed changes
Copy link
Member

@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just want to make sure we make these static since they are local to their translation unit (file).

emmatyping
emmatyping approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure looks unrelated. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

@emmatyping emmatyping emmatyping approved these changes

Assignees
No one assigned
Labels
awaiting merge skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rogdham @AA-Turner @emmatyping