gh-132983: Remove pyzstd in identifiers #133535
Open
+10
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
11 tasks
|
Thanks @emmatyping for the explanation about the context, pinging you for review as suggested 🤗 |
emmatyping
reviewed
May 7, 2025
| @@ -26,8 +26,8 @@ class _zstd.ZstdCompressor "ZstdCompressor *" "clinic_state()->ZstdCompressor_ty | |||
| #define ZstdCompressor_CAST(op) ((ZstdCompressor *)op) | |||
|
|
|||
| int | |||
There was a problem hiding this comment.
Suggested change
| int | |
| static int |
I believe these should have static linkage to keep this scoped to this translation unit.
| @@ -198,7 +198,7 @@ _get_CDict(ZstdDict *self, int compressionLevel) | |||
| } | |||
|
|
|||
| int | |||
There was a problem hiding this comment.
Suggested change
| int | |
| static int |
See above about static linkage.
| @@ -62,7 +62,7 @@ _get_DDict(ZstdDict *self) | |||
|
|
|||
| /* Set decompression parameters to decompression context */ | |||
| int | |||
There was a problem hiding this comment.
Suggested change
| int | |
| static int |
See above about static linkage.
| @@ -121,7 +121,7 @@ _PyZstd_set_d_parameters(ZstdDecompressor *self, PyObject *options) | |||
|
|
|||
| /* Load dictionary or prefix to decompression context */ | |||
| int | |||
There was a problem hiding this comment.
Suggested change
| int | |
| static int |
See above about static linkage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_PyZstd_xxxextern functions were leftover artifacts of the move from pyzstd to cpython.I have renamed them to the
_zstd_xxxconvention used for private functions.