Skip to content

gh-133610: Remove PyUnicode_AsDecoded/Encoded functions #133612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 9, 2025

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented May 7, 2025

@StanFromIreland StanFromIreland requested a review from encukou as a code owner May 7, 2025 20:21
@StanFromIreland StanFromIreland changed the title Remove PyUnicode_AsDecoded/Encoded functions gh-133610: Remove PyUnicode_AsDecoded/Encoded functions May 7, 2025
@StanFromIreland
Copy link
Contributor Author

StanFromIreland commented May 8, 2025

@StanFromIreland
Copy link
Contributor Author

Request: @vstinner

@StanFromIreland StanFromIreland requested a review from vstinner May 8, 2025 15:02
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
Copy link
Member

vstinner commented May 9, 2025

Tests / Ubuntu (free-threading) / build and test (ubuntu-24.04) (pull_request)

test_zstd crash:

0:12:55 load avg: 14.73 [1/3/1] test_zstd worker non-zero exit code (Exit code -11 (SIGSEGV))
Re-running test_zstd in verbose mode (matching: test_compress_locking)
test_compress_locking (test.test_zstd.FreeThreadingMethodTests.test_compress_locking) ...

Fatal Python error: Fatal Python error: Segmentation faultSegmentation fault

@vstinner
Copy link
Member

vstinner commented May 9, 2025

A code search on PyPI top 8,000 projects found 2 projects, but there are only references to these 4 removed functions, these functions are not actually used. So we should be good in terms of impact.

@vstinner vstinner merged commit 4fd1095 into python:main May 9, 2025
43 checks passed
@StanFromIreland StanFromIreland deleted the rem-depr-uni-c-api branch May 9, 2025 15:33
@emmatyping
Copy link
Member

emmatyping commented May 9, 2025

@vstinner @StanFromIreland the zstd crash is noted in #132983 (comment). I'm still trying to figure out the cause/fix for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants