gh-132983: Convert zstd __new__ methods to Argument Clinic #133860
+229
−321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
emmatyping
reviewed
May 12, 2025
| is_raw: bool = False | ||
| If true, perform no checks on *dict_content*, useful for some | ||
| advanced cases. Otherwise, check that the content represents | ||
| a Zstandard dictionary created by the zstd functions. |
There was a problem hiding this comment.
Suggested change
| a Zstandard dictionary created by the zstd functions. | |
| a Zstandard dictionary created by the zstd library or CLI. |
"the zstd functions" sounds a bit awkward here, maybe something like this is a bit better?
emmatyping
reviewed
May 12, 2025
| "a specified format.\n\n" | ||
| "0 means a \"raw content\" dictionary, free of any format restriction, used\n" | ||
| "for advanced user."); | ||
| "The ID of Zstandard dictionary, an integer between 0 and 2**32.\n\n" |
There was a problem hiding this comment.
Suggested change
| "The ID of Zstandard dictionary, an integer between 0 and 2**32.\n\n" | |
| "The ID of the Zstandard dictionary, an int between 0 and 2**32.\n\n" |
emmatyping
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tp_initfunctions intotp_newand convert the latter to AC. This also means we can remove theinitialisedmember from the object structs.ZstdDictto make the content positional-only andis_rawkw-only.A
cc @Rogdham