Skip to content

gh-132983: Convert zstd __new__ methods to Argument Clinic #133860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 12, 2025
Merged

gh-132983: Convert zstd __new__ methods to Argument Clinic #133860

merged 9 commits into from
May 12, 2025
+275 −371

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented May 11, 2025 •
edited by bedevere-app bot
Loading

  • merge the tp_init functions into tp_new and convert the latter to AC. This also means we can remove the initialised member from the object structs.
  • Change the signature of ZstdDict to make the content positional-only and is_raw kw-only.
  • Use Zstandard where appropriate to refer to the compression algorithm, instead of the reference implementation.

A

cc @Rogdham

@AA-Turner AA-Turner requested a review from emmatyping May 11, 2025 02:42
@AA-Turner AA-Turner added skip news needs backport to 3.14 bugs and security fixes labels May 11, 2025
@AA-Turner AA-Turner changed the title gh-133856: Convert zstd __new__ methods to Argument Clinic gh-132983: Convert zstd __new__ methods to Argument Clinic May 11, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 11, 2025
Open
11 tasks
emmatyping
emmatyping approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions but otherwise looks great!

@AA-Turner AA-Turner enabled auto-merge (squash) May 12, 2025 08:24
@AA-Turner AA-Turner merged commit d29ddbd into python:main May 12, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@AA-Turner AA-Turner deleted the zstd-ac-new branch May 12, 2025 08:51
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2025
@AA-Turner @miss-islington
pythongh-132983: Convert zstd __new__ methods to Argument Clinic (p…
8f70e8d 
…ythonGH-133860)

(cherry picked from commit d29ddbd)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented May 12, 2025

GH-133915 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 12, 2025
@encukou encukou mentioned this pull request May 13, 2025
Open
@encukou
Copy link
Member

encukou commented May 13, 2025

Since this was merged, buildbots started showing reference leaks, e.g. here.

@encukou
Copy link
Member

encukou commented May 13, 2025

See #133962 for a fix-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatyping emmatyping emmatyping approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AA-Turner @encukou @emmatyping