Skip to content

gh-138431: JIT Optimizer --- Fix round-tripping references for str and tuple #138458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 3, 2025
Merged

gh-138431: JIT Optimizer --- Fix round-tripping references for str and tuple #138458

merged 5 commits into from
Sep 3, 2025
+34 −8

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Sep 3, 2025 •
edited
Loading

The problem is that when something round-trips through str or tuple, it isn't guaranteed to maintain the same reference information.

The test script deals \with some quirks of immortalization/interning in CPython.

@bedevere-app bedevere-app bot mentioned this pull request Sep 3, 2025
Closed
@Fidget-Spinner Fidget-Spinner added the needs backport to 3.14 bugs and security fixes label Sep 3, 2025
@markshannon
Copy link
Member

I don't think this has anything to do with string interning, but that tuple(t) and str(s) return a new reference to the object.
What was a deferred reference becomes non-deferred when returned from a call.

@Fidget-Spinner
Copy link
Member Author

Fidget-Spinner commented Sep 3, 2025 •
edited
Loading

I don't think this has anything to do with string interning, but that tuple(t) and str(s) return a new reference to the object. What was a deferred reference becomes non-deferred when returned from a call.

Yes I'm aware. Sorry that I didn't put it in the first sentence. What I was talking about (interning/immortalization) is a quirk of why the test script is written that way. For some reason if it's in a separate script, it stays non-immortal but interned, but if it's in the same test file, it stays immortal and interned, causing some weird behavior.

markshannon
markshannon reviewed Sep 3, 2025
View reviewed changes
Fidget-Spinner and others added 2 commits September 4, 2025 01:19
@Fidget-Spinner @markshannon
Address review
bb59d45 
Co-Authored-By: Mark Shannon <9448417+markshannon@users.noreply.github.com>
@Fidget-Spinner
Merge branch 'fix-ref-str-tup' of github.com:Fidget-Spinner/cpython i…
b4a2dd0 
…nto fix-ref-str-tup
markshannon
markshannon approved these changes Sep 3, 2025
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Fidget-Spinner Fidget-Spinner merged commit 2402f84 into python:main Sep 3, 2025
64 checks passed
@miss-islington-app
Copy link

Thanks @Fidget-Spinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@Fidget-Spinner Fidget-Spinner deleted the fix-ref-str-tup branch September 3, 2025 18:05
@miss-islington-app
Copy link

Sorry, @Fidget-Spinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 2402f84665df41732c94db2ccd6f90dd13479fa8 3.14

@Fidget-Spinner Fidget-Spinner removed the needs backport to 3.14 bugs and security fixes label Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon markshannon approved these changes

@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner

Assignees

@Fidget-Spinner Fidget-Spinner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fidget-Spinner @markshannon