Skip to content

gh-138431: JIT Optimizer --- Fix round-tripping references for str and tuple #138458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 3, 2025
Merged

gh-138431: JIT Optimizer --- Fix round-tripping references for str and tuple #138458

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
476535e
JIT: Strip references when roundtripping through str or tuple
Fidget-Spinner Sep 3, 2025
6751f2e
Add tests
Fidget-Spinner Sep 3, 2025
2a99327
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 3, 2025
bb59d45
Address review
Fidget-Spinner Sep 3, 2025
b4a2dd0
Merge branch 'fix-ref-str-tup' of github.com:Fidget-Spinner/cpython i…
Fidget-Spinner Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review 
Co-Authored-By: Mark Shannon <9448417+markshannon@users.noreply.github.com>
  • Loading branch information
@Fidget-Spinner @markshannon
Fidget-Spinner and markshannon committed Sep 3, 2025
commit bb59d45e4fd64a113552beba67ce7918b14ff51c
55 changes: 11 additions & 44 deletions Lib/test/test_capi/test_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2501,54 +2501,21 @@ def testfunc(n):
# For now... until we constant propagate it away.
self.assertIn("_BINARY_OP", uops)

def test_strip_reference_information_through_str(self):
# This test needs to be in another script due to Python's
# string interning details.
script_helper.assert_python_ok('-c', textwrap.dedent("""
import _testinternalcapi
import _opcode

def get_first_executor(func):
code = func.__code__
co_code = code.co_code
for i in range(0, len(co_code), 2):
try:
return _opcode.get_executor(code, i)
except ValueError:
pass
return None
def test_reference_tracking_across_call_doesnt_crash(self):

def iter_opnames(ex):
for item in ex:
yield item[0]
def f1():
for _ in range(TIER2_THRESHOLD + 1):
# Choose a value that won't occur elsewhere to avoid sharing
str("value that won't occur elsewhere to avoid sharing")

def get_opnames(ex):
return list(iter_opnames(ex))
f1()

def testfunc(n):
for _ in range(n):
str("abcde")


testfunc(_testinternalcapi.TIER2_THRESHOLD)
ex = get_first_executor(testfunc)
assert ex is not None
uops = get_opnames(ex)
assert "_POP_TOP_NOP" not in uops
"""))

def test_strip_reference_information_through_tuple(self):
def testfunc(n):
for _ in range(n):
tuple((1,))

testfunc(TIER2_THRESHOLD * 2)

ex = get_first_executor(testfunc)
self.assertIsNotNone(ex)
uops = get_opnames(ex)
def f2():
for _ in range(TIER2_THRESHOLD + 1):
# Choose a value that won't occur elsewhere to avoid sharing
tuple((31, -17, 25, "won't occur elsewhere"))

self.assertNotIn("_POP_TOP_NOP", uops)
f2()


def global_identity(x):
Expand Down