bpo-37444: Update differing exception between builtins and importlib #14869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9592ccd to
314b4a4
Compare
tirkarthi
reviewed
Jul 22, 2019
aeros
reviewed
Jul 26, 2019
Misc/NEWS.d/next/Core and Builtins/2019-07-20-22-34-42.bpo-37444.UOd3Xs.rst
Outdated
Show resolved
Hide resolved
ncoghlan
reviewed
Jul 28, 2019
Misc/NEWS.d/next/Core and Builtins/2019-07-20-22-34-42.bpo-37444.UOd3Xs.rst
Outdated
Show resolved
Hide resolved
brettcannon
approved these changes
Aug 2, 2019
Doc/library/importlib.rst
Outdated
| @@ -1433,13 +1433,18 @@ an :term:`importer`. | |||
| ``importlib.util.resolve_name('sys', __package__)`` without doing a | |||
| check to see if the **package** argument is needed. | |||
|
|
|||
| :exc:`ValueError` is raised if **name** is a relative module name but | |||
| :exc:`ImportError` is raised if **name** is a relative module name but | |||
| package is a false value (e.g. ``None`` or the empty string). | |||
There was a problem hiding this comment.
Suggested change
| package is a false value (e.g. ``None`` or the empty string). | |
| **package** is a false value (e.g. ``None`` or the empty string). |
|
@nsiregar: Status check is done, and it's a failure ❌ . |
1 similar comment
|
@nsiregar: Status check is done, and it's a failure ❌ . |
|
thanks @brettcannon , looks like CI is failing during documentation build and |
|
@nsiregar: Status check is done, and it's a failure ❌ . |
4b2f580 to
b0c8536
Compare
|
@nsiregar: Status check is done, and it's a success ✅ . |
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
…ythonGH-14869) Imports now raise `TypeError` instead of `ValueError` for relative import failures. This makes things consistent between `builtins.__import__` and `importlib.__import__` as well as using a more natural import for the failure. https://bugs.python.org/issue37444 Automerge-Triggered-By: @brettcannon
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…ythonGH-14869) Imports now raise `TypeError` instead of `ValueError` for relative import failures. This makes things consistent between `builtins.__import__` and `importlib.__import__` as well as using a more natural import for the failure. https://bugs.python.org/issue37444 Automerge-Triggered-By: @brettcannon
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
…ythonGH-14869) Imports now raise `TypeError` instead of `ValueError` for relative import failures. This makes things consistent between `builtins.__import__` and `importlib.__import__` as well as using a more natural import for the failure. https://bugs.python.org/issue37444 Automerge-Triggered-By: @brettcannon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports now raise
TypeErrorinstead ofValueErrorfor relative import failures. This makes things consistent betweenbuiltins.__import__andimportlib.__import__as well as using a more natural import for the failure.https://bugs.python.org/issue37444
Automerge-Triggered-By: @brettcannon