-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
Correct typos in the codecs module documentation #15135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@willingc If you have some time, could you also review this one? |
Hi @maggyero. Would you please resubmit this PR without the whitespace changes? It's acceptable to have one or two spaces following a period. It helps a reviewer save time if only the typo corrections or text changes are submitted in a PR. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resubmit without whitespace changes. Thanks @maggyero.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
This reverts commit f77d82d.
Hi @willingc. Thank you for looking at this. Single and double spaces were mixed in this file, that is why I normalized them in my last commit in the first place. But you are right, it is harder to review when there are other corrections involved in the PR, so I reverted them. I have made the requested changes; please review again. |
Thanks for making the requested changes! @willingc: please review the changes made to this pull request. |
@maggyero Travis is reporting errors in linting
Please review and update. Once Travis is green for all checks, please ping me again. |
@willingc Thanks, fixed. I have made the requested changes; please review again. |
Thanks for making the requested changes! @willingc: please review the changes made to this pull request. |
Thanks for reviewing this @willingc. Could we also backport this PR to the 3.7 and 3.8 branches? |
Could you backport this PR to the 3.7 and 3.8 branches? |
Thanks @maggyero for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
Sorry @maggyero and @willingc, I had trouble checking out the |
About to board a flight. If anyone wishes to cherry-pick this, that would be great. Otherwise, it will need to wait until tomorrow. |
No hurry, take your time. |
Hi @willingc. May I request your time to finalize the backport to Python 3.7 and to add the backport label for Python 3.8? |
Thanks @maggyero for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
I'm having trouble backporting to |
Thanks @maggyero for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
GH-16524 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit 891e9e3) Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
Thanks @maggyero for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
GH-16526 is a backport of this pull request to the 3.8 branch. |
(cherry picked from commit 891e9e3) Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
(cherry picked from commit 891e9e3) Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
Thanks @JulienPalard for backporting this. |
This PR will correct typos and punctuation in the
codecs
module documentation.