Skip to content

Correct typos in the codecs module documentation #15135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 12, 2019

Conversation

geryogam
Copy link
Contributor

@geryogam geryogam commented Aug 5, 2019

This PR will correct typos and punctuation in the codecs module documentation.

@geryogam
Copy link
Contributor Author

geryogam commented Aug 7, 2019

@willingc If you have some time, could you also review this one?

@willingc
Copy link
Contributor

willingc commented Aug 7, 2019

Hi @maggyero. Would you please resubmit this PR without the whitespace changes? It's acceptable to have one or two spaces following a period. It helps a reviewer save time if only the typo corrections or text changes are submitted in a PR. Thanks!

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resubmit without whitespace changes. Thanks @maggyero.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@geryogam
Copy link
Contributor Author

geryogam commented Aug 7, 2019

Hi @willingc. Thank you for looking at this. Single and double spaces were mixed in this file, that is why I normalized them in my last commit in the first place. But you are right, it is harder to review when there are other corrections involved in the PR, so I reverted them.

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@willingc: please review the changes made to this pull request.

@willingc
Copy link
Contributor

@maggyero Travis is reporting errors in linting

[1] library/codecs.rst:845: OMG TABS!!!1
1 problem with severity 1 found.

Please review and update. Once Travis is green for all checks, please ping me again.

@geryogam
Copy link
Contributor Author

@willingc Thanks, fixed. I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@willingc: please review the changes made to this pull request.

@geryogam geryogam requested a review from willingc September 12, 2019 06:24
@geryogam
Copy link
Contributor Author

geryogam commented Sep 12, 2019

Thanks for reviewing this @willingc. Could we also backport this PR to the 3.7 and 3.8 branches?

DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@ghost
Copy link

ghost commented Sep 14, 2019

Could you backport this PR to the 3.7 and 3.8 branches?
I have another PR #15732 base on this PR.

@geryogam
Copy link
Contributor Author

@willingc

@miss-islington
Copy link
Contributor

Thanks @maggyero for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @maggyero and @willingc, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 891e9e3b44c99d643dc309a4e63082451271b136 3.7

@willingc
Copy link
Contributor

About to board a flight. If anyone wishes to cherry-pick this, that would be great. Otherwise, it will need to wait until tomorrow.

@ghost
Copy link

ghost commented Sep 14, 2019

No hurry, take your time.
It doesn't matter even next week.

@geryogam
Copy link
Contributor Author

Hi @willingc. May I request your time to finalize the backport to Python 3.7 and to add the backport label for Python 3.8?

@miss-islington
Copy link
Contributor

Thanks @maggyero for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.7. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.7 label.

@miss-islington
Copy link
Contributor

Thanks @maggyero for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-16524 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 1, 2019
(cherry picked from commit 891e9e3)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
@miss-islington
Copy link
Contributor

Thanks @maggyero for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-16526 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 1, 2019
(cherry picked from commit 891e9e3)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
miss-islington added a commit that referenced this pull request Oct 1, 2019
(cherry picked from commit 891e9e3)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
@geryogam
Copy link
Contributor Author

geryogam commented Oct 1, 2019

Thanks @JulienPalard for backporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants