Skip to content

Fix docstring typo in subprocess.py #15812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Conversation

xmatthias
Copy link
Contributor

Fix docstring typo in subprocess.py

it should be will, not wil, otherwise this sentence does not make sense.

@xmatthias xmatthias requested a review from gpshead as a code owner September 9, 2019 18:22
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching this.

@xmatthias
Copy link
Contributor Author

xmatthias commented Sep 9, 2019

give me a bit - i'm moving through CLA

edit: signed it twice now (once before registering and once after - and my github username is attached to the profile).
I hope it'll just need some time to show up on the heroku app.

@miss-islington
Copy link
Contributor

Thanks @xmatthias for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
(cherry picked from commit 182e1d1)

Co-authored-by: Matthias <xmatthias@outlook.com>
@bedevere-bot
Copy link

GH-15854 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
(cherry picked from commit 182e1d1)

Co-authored-by: Matthias <xmatthias@outlook.com>
@bedevere-bot
Copy link

GH-15855 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Sep 10, 2019
(cherry picked from commit 182e1d1)

Co-authored-by: Matthias <xmatthias@outlook.com>
miss-islington added a commit that referenced this pull request Sep 10, 2019
(cherry picked from commit 182e1d1)

Co-authored-by: Matthias <xmatthias@outlook.com>
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants